Use resolved region name in counting length of role name #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in getRoleNameLength
Pull Request Test Coverage Report for Build 127
💛 - Coveralls |
glicht
requested changes
Sep 17, 2019
Member
glicht
left a comment
glicht
left a comment
There was a problem hiding this comment.
Thanks for the contribution. See the small change suggested in my comments.
src/lib/index.ts
Outdated
| for (const part of name_parts) { | ||
| if (part.Ref) { | ||
| length += part.Ref.length; | ||
| length += this.serverless.service.provider.region.length |
Member
There was a problem hiding this comment.
I am concerned with breaking something for someone that has a different ref. Let's use the region only when the ref is AWS::Region.
Suggested change
| length += this.serverless.service.provider.region.length | |
| if (part.Ref === 'AWS::Region') { | |
| length += this.serverless.service.provider.region.length; | |
| } | |
| else { // this is not correct but for maintaining compatibility with previous logic we leave it until we can resolve other ref types | |
| length += part.Ref.length; | |
| } |
glicht
approved these changes
Sep 22, 2019
Member
|
Thanks @maafk . |
Contributor
Author
|
@glicht Can you create a new release with these changes in? |
Contributor
Author
|
@glicht pinging again. The fix is in master, but a release with these changes would be very helpful. Thanks! |
Contributor
Author
|
@glicht Can you please create a release with these changes in it? I'm also happy to help maintain this repo if that would be helpful. Thanks! |
github-actions bot
referenced
this pull request
in andersquist/serverless-iam-roles-per-function
Apr 12, 2022
# [2.1.0](v2.0.2...v2.1.0) (2022-04-12) ### Bug Fixes * change PermissionsBoundary feature to add suport for cloudformation functions ([#70](#70)) ([720dc0f](720dc0f)) * **deps:** updated to latest serverless and making tests work ([d0259c8](d0259c8)) * Function properties schema validation fixed ([#63](#63)) ([1f81264](1f81264)) * Support for Serverless v2.5.0 ([#53](#53)) ([09e56ae](09e56ae)) ### Features * add support to PermissionsBoundary ([d68046e](d68046e)) * Docs: added contributing section ([d9715ba](d9715ba)) * nodejs 12 support ([#32](#32)) ([4dd58a2](4dd58a2)) * schema validation ([abbc8af](abbc8af)) * Support new provider.iam property ([6e20297](6e20297)), closes [#73](#73) * Use resolved region name in counting length of role name ([#33](#33)) ([f9fd677](f9fd677)), closes [#26](#26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26.
Added tests that will fail if the region is not accounted for in getRoleNameLength().