pairing: send the web hand-off to where FxBlox Web actually is - #116
Merged
Conversation
`kBloxWebPairBase` pointed at `https://blox.fx.land/autopin-pair`, which 404s: blox.fx.land has no GitHub Pages DNS record. FxBlox Web is served from the functionland Pages project site under the org's custom domain — `https://docs.fx.land/fxblox-web/` — hence the path prefix. So "Pair in browser" (native fallback + the desktop dialog + the web shell's Pair Blox button) opened a dead page. The fragment carrier, the params and the return template are unchanged; only the base URL moves. User-facing copy now names the product ("FxBlox Web") instead of a domain. Nine strings hardcoded a host that had already gone stale once; naming the product means the next move cannot leave the UI telling users to visit somewhere that does not serve. The unit test asserted `uri.host == 'blox.fx.land'`. It now asserts against `kBloxWebPairBase` and that the path ends in `/autopin-pair`, so it pins the contract — users go where the constant says — without re-hardcoding a host that may move again. All 32 tests pass. Docs (AUTOPIN-HANDOFF.md, architecture.md, README.md) updated to match. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QyQw3WtVXDTtvJKN7ykczw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kBloxWebPairBasepointed athttps://blox.fx.land/autopin-pair, which 404s —blox.fx.landhas no GitHub Pages DNS record.FxBlox Web is served from the functionland Pages project site under the org's custom domain:
https://docs.fx.land/fxblox-web/. So every "Pair in browser" path — the native fallback when the FxBlox app is not installed, the desktop pairing dialog, and the web shell's "Pair Blox" button — opened a dead page.Change
kBloxWebPairBase→https://docs.fx.land/fxblox-web/autopin-pair. The fragment carrier, the three params and the return template are unchanged; only the base URL moves.AUTOPIN-HANDOFF.md,architecture.md,README.md.Test
The unit test asserted
uri.host == 'blox.fx.land'. It now asserts againstkBloxWebPairBaseand that the path ends in/autopin-pair— pinning the contract (users go where the constant says) without re-hardcoding a host that may move again.All 32 tests in
blox_pairing_links_test.dartpass.Verified against the live site
(GitHub Pages returns a 404 status for SPA routes because
404.htmlis a copy ofindex.html— the app boots and the client router takes the route. That is the intended Pages SPA fallback, already set up bypostbuild.mjs.)