fix: re-download cached func CLI binary if not executable#131
Closed
creydr wants to merge 1 commit into
Closed
Conversation
ensureFuncVersion() only checked if the cached binary file existed, not whether it had execute permission. If the binary lost its execute bit (e.g. due to a partial download or filesystem issue in CI), the test would fail with "permission denied" and cascade-fail other specs.
Collaborator
Author
|
Closing in favor of #132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensureFuncVersion()only checked whether the cached old func CLI binary file existed (os.Stat), not whether it was executablefork/exec ... permission denied, cascading into 2 additional Ginkgo interruptsFixes flake observed in https://github.com/functions-dev/func-operator/actions/runs/25655429302/job/75302614248