refactor: extract shared func CLI download with checksum verification#132
Merged
creydr merged 1 commit intoMay 11, 2026
Merged
Conversation
Extract the download, checksum verification, and atomic install logic from the funccli manager into a reusable DownloadAndInstall() function. The test utils now use the same robust pipeline instead of a naive HTTP download, fixing a CI flake where a cached binary lost its execute permission.
Merged
via the queue into
functions-dev:main
with commit May 11, 2026
7d2fb0d
16 of 17 checks passed
Collaborator
Author
|
/cherry-pick release-0.2 |
|
Cherry-pick failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-0.2
git worktree add -d .worktree/cherry-pick-132-to-release-0.2 origin/release-0.2
cd .worktree/cherry-pick-132-to-release-0.2
git switch --create cherry-pick-132-to-release-0.2
git cherry-pick -x 7d2fb0dfe918a781daac7ee00bddebe4f4f675fb |
Collaborator
Author
|
/cherry-pick release-0.3 |
|
Successfully created cherry-pick PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/funccli/manager.gointo a reusableDownloadAndInstall()function ininternal/funccli/download.gotest/utils/func.go) now use the same robust download pipeline instead of a naive HTTP download, gaining checksum verification and atomic installfork/exec ... permission deniedfailures (observed in https://github.com/functions-dev/func-operator/actions/runs/25655429302/job/75302614248)