refactor(animations/motion-reveal) - #70
Open
serum wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| transition={{ | ||
| ...transition, | ||
| ...(delay !== undefined && { delay: delay / 1000 }), | ||
| ...transition, |
Comment on lines
+83
to
+84
| value={String(value)} | ||
| onChange={(key) => { |
There was a problem hiding this comment.
Suggested change
| value={String(value)} | |
| onChange={(key) => { | |
| selectedKey={String(value)} | |
| onSelectionChange={(key) => { |
OptionPicker passes invalid value/onChange props to the app Select component instead of the required selectedKey/onSelectionChange, causing a type error and breaking the showcase's interactive controls.
serum
force-pushed
the
refactor/animations-motion-reveal
branch
from
July 21, 2026 12:50
b82f439 to
318f55d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview: https://taylorui-ritli20bd-functn.vercel.app/animations/motion-reveal
MotionRevealaround a sharedbuildVariants/REVEAL_GEOMETRYtableinstead of per-effect config, and add
offset,duration,amount,repeat,margin, andtransitionprops for per-instance overrides.MotionRevealGroup— wraps a set ofMotionRevealchildren and triggers themas one staggered sequence via a single shared viewport trigger.
MotionRevealIndividual— wraps a set of children and gives each its ownindependent trigger, with no shared trigger or stagger.
offset/duration/easeinmotionRevealDefaults(variants.ts), shared by bothMotionRevealand the rawFramer variants (
fadeUp,zoomIn, etc.); extractEASE_STANDARD/EASE_BOUNCEconstants and dedupe
spin's hardcoded easing ontoEASE_BOUNCE.motion-revealshowcase: swap pill pickers forSelect, add atrigger-margin control and a Replay button, and add dedicated showcases for
MotionRevealGroupandMotionRevealIndividual.motion-reveal/page.mdxdocs to cover all three components — defaults table,props tables, and conceptual notes.
MotionRevealIndividualonanimations/showcase/page.mdx, grouping eachsection (heading, docs, and demo) together with its divider as one reveal unit.