Skip to content

refactor(animations/motion-reveal) - #70

Open
serum wants to merge 1 commit into
feat/animations-libraryfrom
refactor/animations-motion-reveal
Open

refactor(animations/motion-reveal)#70
serum wants to merge 1 commit into
feat/animations-libraryfrom
refactor/animations-motion-reveal

Conversation

@serum

@serum serum commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Preview: https://taylorui-ritli20bd-functn.vercel.app/animations/motion-reveal

  • Rework MotionReveal around a shared buildVariants/REVEAL_GEOMETRY table
    instead of per-effect config, and add offset, duration, amount, repeat,
    margin, and transition props for per-instance overrides.
  • Add MotionRevealGroup — wraps a set of MotionReveal children and triggers them
    as one staggered sequence via a single shared viewport trigger.
  • Add MotionRevealIndividual — wraps a set of children and gives each its own
    independent trigger, with no shared trigger or stagger.

  • Centralize each animation's default offset/duration/ease in
    motionRevealDefaults (variants.ts), shared by both MotionReveal and the raw
    Framer variants (fadeUp, zoomIn, etc.); extract EASE_STANDARD/EASE_BOUNCE
    constants and dedupe spin's hardcoded easing onto EASE_BOUNCE.
  • Rework the motion-reveal showcase: swap pill pickers for Select, add a
    trigger-margin control and a Replay button, and add dedicated showcases for
    MotionRevealGroup and MotionRevealIndividual.
  • Expand motion-reveal/page.mdx docs to cover all three components — defaults table,
    props tables, and conceptual notes.
  • Use MotionRevealIndividual on animations/showcase/page.mdx, grouping each
    section (heading, docs, and demo) together with its divider as one reveal unit.

@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
taylorui Ready Ready Preview, Comment Jul 21, 2026 12:52pm

Request Review

@serum
serum requested a review from AntoniaStr July 16, 2026 14:21
transition={{
...transition,
...(delay !== undefined && { delay: delay / 1000 }),
...transition,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MotionReveal's delay prop (and custom transition override) are silently dropped because the visible variant's own transition replaces the component-level transition prop.

Fix on Vercel

Comment on lines +83 to +84
value={String(value)}
onChange={(key) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value={String(value)}
onChange={(key) => {
selectedKey={String(value)}
onSelectionChange={(key) => {

OptionPicker passes invalid value/onChange props to the app Select component instead of the required selectedKey/onSelectionChange, causing a type error and breaking the showcase's interactive controls.

Fix on Vercel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant