Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the project’s CI to build/test under a MinGW-w64 cross-compilation environment (running produced Windows binaries via Wine) and adds supporting build tooling.
Changes:
- Add a MinGW-w64 toolchain file and a helper script to build MinGW-targeted dependencies (liblo).
- Introduce a CMake wrapper for registering tests that can run under Wine when cross-compiling.
- Update CI workflow matrix to include a new MinGW job and adjust test invocation for Windows.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
test/performance.cpp |
Guards the liblo error callback behind HAVE_LIBLO for non-liblo builds. |
cmake/toolchains/mingw64.cmake |
Adds a MinGW-w64 CMake toolchain definition for cross-compiling to Windows. |
build-mingw-deps |
Adds a script to fetch/build/install liblo into a local prefix for MinGW builds. |
CMakeLists.txt |
Adds rtosc_add_test() to run tests under Wine when using MinGW cross builds. |
.github/workflows/ccpp.yml |
Adds a MinGW CI job and restructures dependency install/update steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@JohannesLorenz I've opened a new pull request, #89, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@JohannesLorenz I've opened a new pull request, #90, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Derive MinGW GCC lib dir dynamically instead of hard-coding version Co-authored-by: JohannesLorenz <1042576+JohannesLorenz@users.noreply.github.com> * Add RESULT_VARIABLE to MinGW GCC detection for better error handling Co-authored-by: JohannesLorenz <1042576+JohannesLorenz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JohannesLorenz <1042576+JohannesLorenz@users.noreply.github.com>
* Initial plan * Guard optional matrix steps with explicit non-empty conditions Co-authored-by: JohannesLorenz <1042576+JohannesLorenz@users.noreply.github.com> * Use truthy check for optional matrix fields instead of != '' comparison Co-authored-by: JohannesLorenz <1042576+JohannesLorenz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JohannesLorenz <1042576+JohannesLorenz@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fundamental Please review, but don't merge yet.