Explicitly guard optional matrix steps in CI workflow#89
Merged
JohannesLorenz merged 3 commits intomingwfrom Mar 16, 2026
Merged
Explicitly guard optional matrix steps in CI workflow#89JohannesLorenz merged 3 commits intomingwfrom
JohannesLorenz merged 3 commits intomingwfrom
Conversation
Open
Co-authored-by: JohannesLorenz <1042576+JohannesLorenz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on MinGW addition to CI setup
Explicitly guard optional matrix steps in CI workflow
Mar 16, 2026
Collaborator
|
@copilot you test only against empty strings. Will your solution also work if the matrix entry does not exist? |
Co-authored-by: JohannesLorenz <1042576+JohannesLorenz@users.noreply.github.com>
Author
Yes — in GitHub Actions expressions, accessing an undefined context property returns an empty string, which is falsy. So both That said, I've switched to the plain truthy form ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps using optional matrix fields (
update,deps1,deps2) relied on GitHub Actions silently no-oping an emptyrunvalue — undocumented behavior that works today but is fragile.Changes
.github/workflows/ccpp.yml: Added&& matrix.config.<field> != ''to theifconditions forupdate system,install deps (1), andinstall deps (2)steps, so they are skipped when the field is absent rather than running an empty command.Only the MinGW matrix entry defines
updateanddeps2; all other entries omit them and will now cleanly skip those steps.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.