Skip to content

v1.4.1 — fix scoped queries silently dropping series (measurement bloom false negatives)

Choose a tag to compare

View all tags
@funkBuild funkBuild released this 25 Aug 07:11
· 44 commits to main since this release
v1.4.1
95f06c4
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

Bug fix

Scoped queries could silently return no series for tag values that exist (#2).

flushDirtyMeasurementBlooms rebuilt a measurement's bloom filter — consulted before every scoped postings lookup — from the in-memory bitmap cache alone after the first full scan. The cache never holds every bitmap, so any tag value not queried since the last full scan dropped out of the bloom at the next rebuild and was rejected before reaching the KV store from then on: a permanent false negative. by {tag} enumeration was unaffected, which is how it was caught (193 of 369 tag values invisible in one production measurement on 1.4.0).

  • Blooms are now always rebuilt from the persisted postings keys.
  • open() schedules a one-time rebuild of every measurement's bloom at the first flush, so upgrading repairs blooms written by ≤1.4.0 with no operator action.
  • Read-only defect: no data or index entries were lost; queries simply under-reported.

Regression test: PostingsBitmapTest.BloomRebuildKeepsSeriesNotResidentInCache.

Assets 2
Loading