Skip to content

Add typing and tests to the plot module#32

Merged
tlambert03 merged 3 commits into
funkelab:mainfrom
tlambert03:plot-typing
Mar 29, 2023
Merged

Add typing and tests to the plot module#32
tlambert03 merged 3 commits into
funkelab:mainfrom
tlambert03:plot-typing

Conversation

@tlambert03

@tlambert03 tlambert03 commented Mar 18, 2023

Copy link
Copy Markdown
Member

does what the title says

@codecov-commenter

codecov-commenter commented Mar 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #32 (e9273ad) into main (b8929ae) will increase coverage by 15.50%.
The diff coverage is 94.73%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main      #32       +/-   ##
===========================================
+ Coverage   77.12%   92.63%   +15.50%     
===========================================
  Files          28       28               
  Lines         752      692       -60     
===========================================
+ Hits          580      641       +61     
+ Misses        172       51      -121     
Impacted Files Coverage Δ
motile/plot.py 93.87% <94.44%> (+93.87%) ⬆️
motile/costs/features.py 81.81% <100.00%> (ø)
motile/solver.py 96.96% <100.00%> (+3.45%) ⬆️

... and 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tlambert03

Copy link
Copy Markdown
Member Author

side note @funkey

I played with making is so that the plot is the default ipython repr of the track graph:

Screen Shot 2023-03-18 at 4 11 32 PM

... but removed it assuming it might be too much to do for a typical graph. But, it might be nice to make a draw() method on the track graph? it could take an optional solver argument to draw solution if not None?

@tlambert03

Copy link
Copy Markdown
Member Author

going to merge this one. @funkey I don't think you'll object, it doesn't change any functionality, just adds tests and typing

@tlambert03
tlambert03 merged commit 8f0a2f3 into funkelab:main Mar 29, 2023
@tlambert03
tlambert03 deleted the plot-typing branch March 29, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants