Use gzip's GzipFile to manage compression/decompression #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came about due to a recent change rolled out by AppVeyor at the beginning of this month. ref: https://www.appveyor.com/blog/
8 tasks
Fix README badges
Mirrors variable naming within `encode` in `decode`.
To handle compression and decompression with the GZip format in a Python 2/3 compatible way, use a `GzipFile` instance backed by an in-memory `BytesIO` buffer for reading and writing from. Offloads the manual header and footer handling to the Python builtin `gzip` module simplifying the code a bit.
As the compression/decompression strategy has changed to handle headers and footers, update the fixtures accordingly.
Author
|
Just as a note, had merged in upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to zarr-developers#87
Makes use of the builtin
gzipmodule'sGzipFilebacked by aBytesIObuffer to manage compression/decompression. Avoids handling the messy details of the GZip format by letting Python do them for us. Should catch some other format subtleties (e.g. optional headers, footers) as well as handling any checksum issues that might occur.