Auto-mount active plugin routes and export core plugins via @sonicjs-cms/core/plugins by Copilot · Pull Request #1 · furelid/sonicjs

Copilot · 2026-05-08T11:15:02Z

…with modal

Signed-off-by: Johan Furelid <johan@furelid.com>

…d user feedback

Agent-Logs-Url: https://github.com/furelid/sonicjs/sessions/c1a00f35-a127-4cbf-9f68-be6537a434ac

furelid

We already have the canonical manifest source in code: packages/core/src/plugins/plugin-registry.ts (auto-generated) includes is_core: boolean, so we can enforce the policy without hardcoded lists.

Essential request: core plugins (is_core: true) must always be enabled (never 404 due to DB/config gating).

Proposed approach (minimal + flexible):

Extend mountPluginManagerRoutes() options with an isCorePlugin?: (pluginName: string) => boolean.
In shouldEnablePlugin(), short-circuit:
- if (isCorePlugin(pluginName)) return true
In createSonicJSApp(), provide:
- isCorePlugin: (name) => getPlugin(name)?.is_core === true (from plugin-registry.ts)

This uses the generated registry as the single source of truth and still allows plugins shipped in packages/core with is_core: false (e.g. global-variables, security-audit) to remain gated by DB/config as intended.

Copilot

Pull request overview

This PR fixes a core integration gap where plugin routes collected via PluginBuilder.addRoute() were not being mounted into the main Hono app, causing active/enabled plugins (e.g. global-variables) to return 404. It also expands the public @sonicjs-cms/core/plugins barrel exports and simplifies the sample app to rely on core auto-mounting.

Changes:

Add mountPluginManagerRoutes() and use it in createSonicJSApp() to mount/guard core plugin routes before core/admin catch-all routing.
Expand packages/core/src/plugins/index.ts to publicly export core plugins and helpers via @sonicjs-cms/core/plugins.
Add a regression unit test for enabled vs inactive plugin route mounting, and clean up a few internal/self-imports.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/core/src/plugins/plugin-manager.ts	Extracts route registration into `registerPluginRoutes()` and reuses it during extension registration.
packages/core/src/plugins/index.ts	Adds public re-exports for core plugins and related helpers/services.
packages/core/src/plugins/core-plugins/otp-login-plugin/index.ts	Avoids unused destructured field by renaming to `_isActive`.
packages/core/src/plugins/available/email-templates-plugin/services/email-renderer.ts	Switches `renderTemplate` import to a source-relative utils import.
packages/core/src/app.ts	Implements `mountPluginManagerRoutes()` and uses it to auto-mount core plugin routes with enablement gating.
packages/core/src/tests/utils/utils.template-renderer.test.ts	Updates imports to source-relative utils.
packages/core/src/tests/plugins/plugin-route-mounting.test.ts	Adds regression coverage for enabled vs inactive plugin route mounting behavior.
packages/core/src/tests/middleware/middleware.permissions.test.ts	Updates imports to source-relative middleware exports.
my-sonicjs-app/src/index.ts	Removes comments/structure implying manual core plugin route wiring; keeps manual mounting for app-local plugins only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

furelid · 2026-05-08T13:16:14Z

+      isPluginEnabled: async (pluginName, c) => {
+        if (config.plugins?.disableAll) {
+          return false
+        }
+
+        return isPluginActive(c.env.DB, pluginName)
+      },


What is the best approach as you are the most senior and experienced developer with years of knowledge and experience

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix SVG D1 inserts and add commenting guidelines

furelid · 2026-05-08T13:56:10Z

+          return false
+        }
+
+        return isPluginActive(c.env.DB, pluginName)


Response to https://github.com/furelid/sonicjs/pull/1/changes#r3208714130:

In the current implementation enabledPlugins is ignored when isPluginEnabled is provided, so disableAll isn’t bypassable today. To make this precedence explicit and prevent future regressions, I’ll add disableAll?: boolean to PluginRouteMountOptions and short-circuit it at the top of shouldEnablePlugin().

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

+    if (options.isPluginEnabled !== undefined) {
+      return await isPluginEnabled(pluginName, c)
+    }
+
+    return enabledPlugins.has(pluginName)


+        if (config.plugins?.disableAll) {
+          return false
+        }
+
+        return isPluginActive(c.env.DB, pluginName)


+                class="inline-flex items-center gap-x-1.5 px-3.5 py-2.5 bg-zinc-950 dark:bg-white text-white dark:text-zinc-950 font-semibold text-sm rounded-lg hover:bg-zinc-800 dark:hover:bg-zinc-100 transition-colors shadow-sm"
+              >
+                <svg class="h-5 w-5" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+                  <path d="M7 8L3 11.6923L7 16M17 8L21 11.6923L17 16M14 4L10 20" stroke="#000000" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"/>


+              <p class="text-xs text-zinc-500 dark:text-zinc-400">
+                This is a code-based representation of ${data.display_name ? `the ${data.display_name}` : 'this'} collection.
+                Learn more about
+                <a href="https://sonicjs.com/collections" target="_blank" class="text-blue-600 dark:text-blue-400 hover:underline">


+       * Code Export Modal Logic
+       */
+
+      let collectionName = '${data.name || ''}'; 


+       * Selects the textarea content and attempts to copy it to the clipboard, providing user feedback on success or failure.
+       */
+      codeExportModalContainer.querySelector('#copy-options-btn')
+        .addEventListener('click', function() {
+          const textarea = codeExportModalContainer.querySelector('#code-export-options');
+          textarea.select();
+          textarea.setSelectionRange(0, 99999); // For mobile devices
+
+          try {
+            const successful = document.execCommand('copy');
+            if (successful) {
+              const feedback = codeExportModalContainer.querySelector('#copy-options-feedback');
+              feedback.classList.remove('invisible');
+              setTimeout(() => feedback.classList.add('invisible'), 2000);
+            } else {
+              throw new Error('Copy command was unsuccessful');
+            }
+          } catch (err) {
+            console.error('Error copying to clipboard:', err);


…e plugin active status - Add `isCorePlugin?: (pluginName) => boolean` to PluginRouteMountOptions so core plugins (is_core === true in manifest-registry) are always enabled and bypass disableAll - Add `disableAll?: boolean` to PluginRouteMountOptions with explicit precedence: core plugins skip it, others are blocked - Use `getPlugin(name)?.is_core === true` from manifest-registry as the isCorePlugin implementation in createSonicJSApp() - Add module-level TTL cache (60s) for isPluginActive DB queries to avoid a D1 read on every request in the hot path - All 1475 unit tests pass Agent-Logs-Url: https://github.com/furelid/sonicjs/sessions/6a6dbe7b-ef8b-4d96-89b1-1359dcd3b85c

- Document SonicJSConfig.plugins.disableAll and enabled fields with JSDoc explaining their interaction with isCorePlugin gating - Document the TTL cache invalidation window and memory boundedness Agent-Logs-Url: https://github.com/furelid/sonicjs/sessions/6a6dbe7b-ef8b-4d96-89b1-1359dcd3b85c

…ate.ts

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

furelid · 2026-05-08T14:20:16Z

+    if (options.isPluginEnabled !== undefined) {
+      return await isPluginEnabled(pluginName, c)
+    }
+
+    return enabledPlugins.has(pluginName)


Consider the argument and adjust the code. https://github.com/furelid/sonicjs/pull/1/changes#r3209181998

@deprecated

… subpath exports Combines this branch's user-plugin work with the changes from furelid#1 (furelid#1). The two PRs solved different problems and are complementary; this commit takes both. From furelid #1: - mountPluginManagerRoutes(app, plugins[], options) replaces the 9 duplicated route-mount loops in createSonicJSApp. Each core plugin's routes are now gated by a per-request guard that checks `is_active` in the plugins table — flipping the toggle in the admin UI now actually affects route resolution. - 60s TTL cache (pluginStatusCache) so the gate is one Map lookup on the hot path; one D1 read per plugin per minute amortized. - isCorePlugin callback bypasses gating for plugins with is_core === true in their manifest (database-tools, seed-data, core-cache, etc.). - plugins.enabled?: string[] for explicit allowlists when DB gating is disabled. - @sonicjs-cms/core/plugins subpath now exports aiSearchPlugin, analyticsPlugin, globalVariablesPlugin, oauthProvidersPlugin, securityAuditPlugin, OAuthService, BUILT_IN_PROVIDERS, stripePlugin, shortcodesPlugin, etc. so advanced users can wrap or compose them. - Tightens a few imports that were going through the public package re-export back to the source modules. Kept from this branch: - plugins.register?: Plugin[] for user plugins, mounted via mountPlugin() (no DB gating — if the user imported and registered it, they want it on). - @deprecated marks on plugins.directory and plugins.autoLoad. - Doc + blog post fixes. User plugins still bypass the new gating system. Adding them to mountPluginManagerRoutes with isCorePlugin: () => false is a small follow-up so the admin "disable plugin" toggle applies to user plugins too. All 1486 unit tests pass (1479 mine + furelid + 2 plugin-route-mounting + 5 createSonicJSApp integration smoke tests). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

furelid and others added 5 commits May 8, 2026 02:51

feat(admin): add export functionality for config-managed collections …

cab4f42

…with modal

dco commitment

49e9b9a

Signed-off-by: Johan Furelid <johan@furelid.com>

dco commitment with gpg

6a6f710

Signed-off-by: Johan Furelid <johan@furelid.com>

feat(admin): enhance code export modal with improved functionality an…

50b79fd

…d user feedback

Initial plan

41c36db

Copilot AI assigned Copilot and furelid May 8, 2026

Copilot started work on behalf of furelid May 8, 2026 11:15 View session

Copilot AI added 3 commits May 8, 2026 11:32

fix: auto-mount active plugin routes

ab09b5a

Agent-Logs-Url: https://github.com/furelid/sonicjs/sessions/c1a00f35-a127-4cbf-9f68-be6537a434ac

fix: auto-mount active plugin routes

213ed50

Agent-Logs-Url: https://github.com/furelid/sonicjs/sessions/c1a00f35-a127-4cbf-9f68-be6537a434ac

fix: auto-mount active plugin routes

508025f

Agent-Logs-Url: https://github.com/furelid/sonicjs/sessions/c1a00f35-a127-4cbf-9f68-be6537a434ac

Copilot AI changed the title ~~[WIP] Fix plugin routes not mounting in Hono app for issue #758~~ Auto-mount active plugin routes and export core plugins via @sonicjs-cms/core/plugins May 8, 2026

Copilot AI requested a review from furelid May 8, 2026 11:41

Copilot finished work on behalf of furelid May 8, 2026 11:41

furelid reviewed May 8, 2026

View reviewed changes

furelid requested a review from Copilot May 8, 2026 12:36

Copilot started reviewing on behalf of furelid May 8, 2026 12:37 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Copilot started work on behalf of furelid May 8, 2026 13:06 View session

Copilot finished work on behalf of furelid May 8, 2026 13:08

Copilot AI requested a review from furelid May 8, 2026 13:08

Copilot AI temporarily deployed to internal May 8, 2026 13:11 Inactive

Apply suggestions from code review

9b12585

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

furelid temporarily deployed to internal May 8, 2026 13:19 — with GitHub Actions Inactive

furelid force-pushed the main branch from 9fa8db3 to d1d0e8d Compare May 8, 2026 13:28

Merge pull request #2 from furelid/main

681297d

Fix SVG D1 inserts and add commenting guidelines

furelid temporarily deployed to internal May 8, 2026 13:39 — with GitHub Actions Inactive

furelid reviewed May 8, 2026

View reviewed changes

furelid requested a review from Copilot May 8, 2026 13:58

Copilot started reviewing on behalf of furelid May 8, 2026 13:58 View session

Copilot started work on behalf of furelid May 8, 2026 14:01 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Copilot AI added 2 commits May 8, 2026 14:06

Copilot finished work on behalf of furelid May 8, 2026 14:11

Copilot AI requested a review from furelid May 8, 2026 14:11

Delete packages/core/src/templates/pages/admin-collections-form.templ…

16563c6

…ate.ts

furelid temporarily deployed to internal May 8, 2026 14:16 — with GitHub Actions Inactive

Potential fix for pull request finding

8520e0d

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

furelid temporarily deployed to internal May 8, 2026 14:21 — with GitHub Actions Inactive

furelid reviewed May 8, 2026

View reviewed changes

Update print statement from 'Hello' to 'Goodbye'

f72bcf0

furelid temporarily deployed to internal May 8, 2026 14:29 — with GitHub Actions Inactive

Downgrade sonicjs version from 2.18.1 to 2.18.0

44413b8

furelid deployed to internal May 8, 2026 14:31 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-mount active plugin routes and export core plugins via @sonicjs-cms/core/plugins#1

Auto-mount active plugin routes and export core plugins via @sonicjs-cms/core/plugins#1
Copilot wants to merge 16 commits into
mainfrom
copilot/fix-plugin-auto-mounting-issue-758

Copilot AI commented May 8, 2026 •

edited

Loading

Uh oh!

furelid left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

furelid May 8, 2026

Uh oh!

furelid May 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

furelid May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

furelid left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

furelid May 8, 2026

Choose a reason for hiding this comment

Uh oh!

furelid May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

furelid May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 8, 2026 •

edited

Loading