Fix modal blur navigation - #39
Merged
Merged
Conversation
Capture the window behind transition containers so navigation-backed modals blur visible root content instead of an empty container.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| let referenceView: UIView? = navBar.superview ?? self.view | ||
| let cellFrame: CGRect = cell.convert(cell.bounds, to: referenceView) | ||
| let navBarFrame: CGRect = navBar.convert(navBar.bounds, to: referenceView) | ||
| if navBarFrame.intersects(cellFrame) { self.navigationController?.setNavigationBarHidden(true, animated: true) } |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 128 characters (line_length)
| internal class FluidBlurredBackgroundView: BlurView, FluidBackgroundCompatible { | ||
| internal class FluidBlurredBackgroundView: UIView, FluidBackgroundCompatible { | ||
| private static let ciContext = CIContext(options: nil) | ||
| private static let blurQueue = DispatchQueue(label: "Fluidable.FluidBlurredBackgroundView.blur", qos: .userInitiated) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 121 characters (line_length)
| blue: CGFloat(pixel[2]) / 255, | ||
| alpha: CGFloat(pixel[3]) / 255) | ||
| } | ||
| } |
There was a problem hiding this comment.
File Length Violation: File should contain 400 lines or less: currently contains 3320 (file_length)
|
|
||
| let visibleView: XCUIElement = app.otherElements.element(matching: .other, identifier: model.visibleControllerViewAccessibilityIdentifier) | ||
| let scrollView: XCUIElement = app.scrollViews.element(matching: .scrollView, identifier: model.parentScrollViewAccessibilityIdentifier) | ||
| let scrollTopView: XCUIElement = app.otherElements.element(matching: .other, identifier: model.parentScrollTopViewAccessibilityIdentifier) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 146 characters (line_length)
| self.assertEventually(optionButton.exists) | ||
|
|
||
| let visibleView: XCUIElement = app.otherElements.element(matching: .other, identifier: model.visibleControllerViewAccessibilityIdentifier) | ||
| let scrollView: XCUIElement = app.scrollViews.element(matching: .scrollView, identifier: model.parentScrollViewAccessibilityIdentifier) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 143 characters (line_length)
| let optionButton = app.buttons["Option"] | ||
| self.assertEventually(optionButton.exists) | ||
|
|
||
| let visibleView: XCUIElement = app.otherElements.element(matching: .other, identifier: model.visibleControllerViewAccessibilityIdentifier) |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 146 characters (line_length)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification