Fix modal dismiss table truncation - #40
Merged
Merged
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| }) | ||
| animators.append(constraintAnimator) | ||
| /* NOTE: Table cell layout (UIViewPropertyAnimator) */ | ||
| let cellLayoutAnimator: FluidPropertyAnimator = .init(duration: duration, easing: easing, id: "cellLayoutAnimator (Dismiss)") |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 133 characters (line_length)
| }) | ||
| animators.append(constraintAnimator) | ||
| /* NOTE: Table cell layout (UIViewPropertyAnimator) */ | ||
| let cellLayoutAnimator: FluidPropertyAnimator = .init(duration: duration, easing: easing, id: "cellLayoutAnimator (Dismiss)") |
There was a problem hiding this comment.
Line Length Violation: Line should be 120 characters or less: currently 133 characters (line_length)
| let navigation = UINib(nibName: "NavigationRootNavigationController", bundle: bundle) | ||
| .instantiate(withOwner: nil, options: nil).first as! NavigationRootNavigationController | ||
| let destination = UINib(nibName: "NavigationTableViewController", bundle: bundle) | ||
| .instantiate(withOwner: nil, options: nil).first as! NavigationTableViewController |
There was a problem hiding this comment.
Force Cast Violation: Force casts should be avoided. (force_cast)
| let model: RootModel = .navigationFluidFullScreen | ||
| let bundle = Bundle(for: FluidModalTableDismissalLayoutTests.self) | ||
| let navigation = UINib(nibName: "NavigationRootNavigationController", bundle: bundle) | ||
| .instantiate(withOwner: nil, options: nil).first as! NavigationRootNavigationController |
There was a problem hiding this comment.
Force Cast Violation: Force casts should be avoided. (force_cast)
| func testConstrainsTableCellLabelsToDismissTargetWidth() { | ||
| let bundle = Bundle(for: FluidModalTableDismissalLayoutTests.self) | ||
| let cell = UINib(nibName: "TableCell", bundle: bundle) | ||
| .instantiate(withOwner: nil, options: nil).first as! TableCell |
There was a problem hiding this comment.
Force Cast Violation: Force casts should be avoided. (force_cast)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
xcodebuild build-for-testing -project Fluidable.xcodeproj -scheme FluidableExample -destination 'platform=iOS Simulator,name=iPhone 17'failed withTableCell has no member 'layoutTextLabels'xcodebuild test -project Fluidable.xcodeproj -scheme FluidableExample -destination 'platform=iOS Simulator,name=iPhone 17' -only-testing:FluidableUITests/FluidModalTableDismissalLayoutTestsxcodebuild test -project Fluidable.xcodeproj -scheme FluidableExample -destination 'platform=iOS Simulator,name=iPhone 17' -only-testing:FluidableUITests/NavigationFluidFullScreenDismissUITests/testFinishAnimatedDismissWithTableContentswiftlint lint Example/Source/Control/NavigationTableViewController.swift Example/Source/Control/TransitionTableViewController.swift Example/Source/View/TableCell.swift Example/Source/View/TableView.swift Example/Source/View/HeaderCell.swift Example/Source/Helper/Extensions.swift UITests/MainSpec.swiftgit diff --check