Remove remaining Supabase clients and drop @supabase/supabase-js#90
Merged
Conversation
- Delete RecentTradesDataLayer.jsx (never rendered in prod: ENABLE_SUBGRAPH_FOR_ALL_PROPOSALS forces the subgraph path) - Strip Supabase client + candle/trade fetch paths from MarketPageShowcaseViewModel and MarketHistoryViewModel (subgraph/SQL-direct paths kept) - Remove @supabase/supabase-js from package.json and lockfile Netlify prod env has no Supabase vars, so all removed code was dead weight. scripts/generate-seo.mjs still references Supabase but only runs via the optional build-with-seo script; replacing it with a registry-fed generator is tracked separately.
✅ Deploy Preview for futarchy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Finishes the Supabase purge that #88 started. #88 only removed Supabase from the two bug-path files; three files still constructed live clients (one with a hardcoded project URL) and the npm dependency remained.
RecentTradesDataLayer.jsx— live client from env vars + realtime channels. Never rendered in prod:ENABLE_SUBGRAPH_FOR_ALL_PROPOSALS = true(featureFlags.js) forcesuseSubgraphTrades, so the ternary always picksSubgraphTradesDataLayer.MarketPageShowcaseViewModel.jsx— removed module-level client (hardcodednvhqdqtlsdboctqjcelq.supabase.co) and Supabase candle fetches; subgraph path kept.MarketHistoryViewModel.jsx— removed guarded client init,fetchTradeHistoryFromSupabase, dead edge-function endpoint, and realtime subscription effect. Exports consumed by MarketPageShowcase (getFormattedTrades,openTransactionInExplorer,useTradeHistory) preserved.@supabase/supabase-jsfrom package.json + lockfile.Verified
grep -rn "@supabase" src/ package.json→ zero hits; lockfile has zero@supabaseentries.futarchy-sdksub-package still declares its own@supabase/supabase-js, but src only imports its three executor cartridges, which import onlyviem+ a local util — no transitive pull into the interface build.npm run build(static export) passes.OPS_SIGNER_ACCESS_KEY— no Supabase vars — so everything removed was already dead in production.Intentionally left
scripts/generate-seo.mjsstill reads Supabase (market_event,ai_prompts) — build-time only, via the optionalbuild-with-seoscript. Rewriting it registry-fed is Tier 0 of the self-serve program (hub-9du).futarchy-sdkinternals not consumed by the app).🤖 Generated with Claude Code