Add Helm chart, deploy workflow, and staging support for MCP server#201
Merged
Add Helm chart, deploy workflow, and staging support for MCP server#201
Conversation
Contributor
Author
|
@claude code review |
This comment was marked as outdated.
This comment was marked as outdated.
4f7b3d7 to
7ceb980
Compare
Contributor
Author
|
@claude code review |
This comment was marked as outdated.
This comment was marked as outdated.
a89e4e7 to
9948527
Compare
Restore deployment infra deferred from PR #165, updated for current codebase: Helm chart (everyrow-mcp/deploy/chart/): - Deployment with /health probes, rolling update, hyperdisk tolerations - ClusterIP Service (80 -> 8000) - Gateway API HTTPRoute using .Release.Namespace for staging isolation - SOPS-encrypted secrets via GCP KMS (Supabase keys, URLs, Redis config) GitHub Actions workflow (.github/workflows/deploy-mcp.yaml): - PR trigger: runs checks only (ruff, pytest, basedpyright) - Manual dispatch with deploy_production / deploy_staging toggles - Pipeline: setup -> checks -> build-and-push (GAR) -> deploy (Helm) - Slack notification on failure, --atomic rollback Staging environment: - Namespace: everyrow-mcp-staging - Staging Supabase, Redis DB 14, mcp-staging.everyrow.io - Values overlay: values.yaml + values.staging.yaml + staging secrets Sensitive values (Supabase URLs, Redis endpoints) are in SOPS-encrypted files, not in plain values.yaml, since the repo is public. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9948527 to
dd09007
Compare
jackwildman
approved these changes
Feb 24, 2026
hnykda
reviewed
Feb 25, 2026
Comment on lines
+3
to
+6
| SUPABASE_ANON_KEY: ENC[AES256_GCM,data:SDHdb1p3B56tCsZDMY+8rM/+fSZCJmZito/fmHsqChlPOqRmI2vNLOLIfavbEw==,iv:qotbOW4BUeyRAL8kAFpZ5iOwCDyjeOynlDNG1/a6NRc=,tag:SH7yEMGyS0NlIdDnPmPIsQ==,type:str] | ||
| SUPABASE_URL: ENC[AES256_GCM,data:c4UIrv/WFIqENnjQlMHn4RqJ/lJ6d8fWSyoYlswZOmM/Is8ohp2U4w==,iv:g6VSbaEwH9cn+pL9BhO5R4uLvLue4GCCHew5HZSy5go=,tag:BP0NESsL2E7vwc4aMyn2+g==,type:str] | ||
| REDIS_SENTINEL_ENDPOINTS: ENC[AES256_GCM,data:9SS/lteI3EANPDYzWdZZWq3x0Bl30EgSorUesY2vS1BPKCs=,iv:7+XnRIZrRG25Rjg7N+u34gDW4iVbHPzQbJ8pp39L6ao=,tag:N+WFMVUwKRA6H1ro1bbtZw==,type:str] | ||
| REDIS_SENTINEL_MASTER_NAME: ENC[AES256_GCM,data:iL8r8pQ4TIU=,iv:xFSpe5B3NJtKOqWZCgqFihxfVOFSe/ysJDE37Ak/vW4=,tag:AXTyzU7m3u/eqfqCgm1slA==,type:str] |
Contributor
There was a problem hiding this comment.
none of this should be in the secrets (maybe the endpoints if they contain password), should be env
RafaelPo
added a commit
that referenced
this pull request
Feb 25, 2026
SUPABASE_URL, REDIS_SENTINEL_ENDPOINTS, and REDIS_SENTINEL_MASTER_NAME are infrastructure addresses, not credentials. They don't grant access without the corresponding keys/passwords which remain SOPS-encrypted. Addresses PR #201 review feedback from @hnykda. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
RafaelPo
added a commit
that referenced
this pull request
Feb 25, 2026
SUPABASE_URL, REDIS_SENTINEL_ENDPOINTS, and REDIS_SENTINEL_MASTER_NAME are infrastructure addresses, not credentials. They don't grant access without the corresponding keys/passwords which remain SOPS-encrypted. Addresses PR #201 review feedback from @hnykda. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-adds deployment infrastructure deferred from PR #165 (commits
390c80e3and61819ca2removed the Helm chart and deploy workflow). Updated for the current codebase, with staging support and security hardening for the public repo.Helm chart (
everyrow-mcp/deploy/chart/)/healthprobes, rolling update, hyperdisk node tolerations{{ .Release.Name }}for resource names — staging resources get distinct names (everyrow-mcp-staging,everyrow-mcp-staging-secrets){{ .Release.Namespace }}for namespace isolationGitHub Actions workflow (
.github/workflows/deploy-mcp.yaml)deploy_production/deploy_stagingboolean toggles — no auto-deploy--atomicrollback +cancel-in-progress: false(safe for deploys)Staging environment
deploy_production=truedeploy_staging=trueeveryrow-mcpeveryrow-mcp-stagingeveryrow-mcpeveryrow-mcp-stagingmcp.everyrow.iomcp-staging.everyrow.ioEVERYROW_API_URLis intentionally not overridden for staging — there is no staging API. Both environments use the production EveryRow API.Security (public repo)
Sensitive values (Supabase URLs, anon keys, Redis Sentinel endpoints) are in SOPS-encrypted files, not in plain
values.yaml.Other changes
REDIS_DB = 13constant fromredis_store.py— usesettings.redis_dbdirectlyHow to deploy
Before first deploy
mcp.everyrow.ioandmcp-staging.everyrow.iopoints to the shared TLS gatewayTest plan
helm lintpasseshelm templaterenders correct YAML for both prod and stagingeveryrow-mcpvseveryrow-mcp-staging).Release.Namespacedeploy_staging=truedeploys to stagingdeploy_production=truedeploys to production🤖 Generated with Claude Code