Move non-secret config from SOPS secrets to plain env vars#219
Merged
Conversation
SUPABASE_URL, REDIS_SENTINEL_ENDPOINTS, and REDIS_SENTINEL_MASTER_NAME are infrastructure addresses, not credentials. They don't grant access without the corresponding keys/passwords which remain SOPS-encrypted. Addresses PR #201 review feedback from @hnykda. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RafaelPo
added a commit
that referenced
this pull request
Feb 25, 2026
PR #219 moved SUPABASE_URL, REDIS_SENTINEL_ENDPOINTS, and REDIS_SENTINEL_MASTER_NAME from secrets to plain env vars in values.yaml. During a rolling update, the K8s Secret is replaced first (removing those vars), causing the old pod to crash before the new pod is ready — breaking the deployment. Add these vars back to both staging and production SOPS files so both old and new pods can find them during the transition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPABASE_URL,REDIS_SENTINEL_ENDPOINTS, andREDIS_SENTINEL_MASTER_NAMEfrom SOPS-encrypted secrets to plainenvvars invalues.yamlsecrets.enc.yamlandsecrets.staging.enc.yamlto contain only actual credentials (SUPABASE_ANON_KEY,REDIS_PASSWORD)Rationale
These values are infrastructure addresses/config names, not credentials:
SUPABASE_URL— public HTTPS endpoint, useless without the anon keyREDIS_SENTINEL_ENDPOINTS— cluster-internal DNS, useless without the passwordREDIS_SENTINEL_MASTER_NAME— justmymaster, a config labelOver-encrypting non-secrets adds KMS dependency for routine config changes and obscures what's actually sensitive.
Test plan
sops -d secrets.enc.yamlreturns onlySUPABASE_ANON_KEYandREDIS_PASSWORDsops -d secrets.staging.enc.yamlreturns onlySUPABASE_ANON_KEYandREDIS_PASSWORDkubectl exec ... -- env)🤖 Generated with Claude Code