Restore env vars in secrets for rolling update compatibility#226
Closed
Restore env vars in secrets for rolling update compatibility#226
Conversation
PR #219 moved SUPABASE_URL, REDIS_SENTINEL_ENDPOINTS, and REDIS_SENTINEL_MASTER_NAME from secrets to plain env vars in values.yaml. During a rolling update, the K8s Secret is replaced first (removing those vars), causing the old pod to crash before the new pod is ready — breaking the deployment. Add these vars back to both staging and production SOPS files so both old and new pods can find them during the transition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPABASE_URL,REDIS_SENTINEL_ENDPOINTS, andREDIS_SENTINEL_MASTER_NAMEback to SOPS secretsvalues.yamlenv vars in PR Move non-secret config from SOPS secrets to plain env vars #219, but during a rolling update the K8s Secret is replaced first — the old pod loses those vars fromenvFromand crashes before the new pod (which has them asenv) is readyenvtakes precedence overenvFromRoot cause
Old pod gets restarted during rolling update → picks up new Secret (without SUPABASE_URL) → crashes → deployment times out → rollback
Test plan
🤖 Generated with Claude Code