Skip to content

fix(gen-zig): discard unused parameters and declare test/bench block bindings - #1911

Merged
gHashTag merged 1 commit into
masterfrom
fix/zig-unused-params
Aug 8, 2026
Merged

fix(gen-zig): discard unused parameters and declare test/bench block bindings#1911
gHashTag merged 1 commit into
masterfrom
fix/zig-unused-params

Conversation

@gHashTag

@gHashTag gHashTag commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Two Zig-backend output-validity fixes, measured against tri-net's 68 legacy specs with zig ast-check (0.15.2): parameters the body never reads get a _ = param; discard, and the first assignment to a plain identifier in a test/bench block lowers to const name = expr; (bindings parse as StmtAssign -- the Zig twin of the Verilog testbench defect #1894). Invalid gens drop 66/68 -> 38/68; the remaining three mechanical classes (tuple destructuring LHS, un-translated [T;N] array types, unused local consts) are tracked in #1910 for full zig-leg restoration in tri-net.

Unit suite 1537/1537 (== master); gen-rust output byte-identical (Zig-only change). FROZEN_HASH resealed; NOW.md + docs/NOW.md updated.

Closes #1910

🤖 Generated with Claude Code

…bindings

Two Zig-backend output-validity fixes, measured against tri-net's 68 legacy
specs with zig ast-check: (1) parameters the body never reads get a
'_ = param;' discard (Zig errors on unused fn parameters); (2) the first
assignment to a plain identifier in a test/bench block lowers to
'const name = expr;' -- bindings parse as StmtAssign, not StmtLocal, so the
emitted assignment referenced an undeclared name (the Zig twin of the
Verilog testbench defect #1894). Invalid gens drop 66/68 -> 38/68; the
remaining three mechanical classes (tuple destructuring LHS, un-translated
[T;N] array types, unused local consts) are tracked in #1910. Unit suite
1537/1537; gen-rust output byte-identical. FROZEN_HASH resealed.

Closes #1910

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-08 03:41:19 UTC

Summary

Status Count
Total Open PRs 14
PRs with Failing Checks 1
PRs with All Checks Green 13
READY 5
FAILING 1
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=7fff8f7dd495 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gen (Zig): unused params + undeclared test bindings fixed; three classes remain before zig output compiles

1 participant