fix(gen-verilog): lower tuple-LITERAL destructure -- last icarus compile-error class - #1988
Merged
Merged
Conversation
…ile-error class Refs #1948 `let (a, b, c) = (4, 3, 1)` -- destructuring a tuple LITERAL rather than a call -- was unhandled: tuple_local_elem_types only recognized typed or call-returning inits, so the local emitted a nameless `reg [31:0] ;` and `= {1, 3, 4}` (empty LHS). It now infers the element types (default u32) and width-casts the literal elements into the packed temp. tri-net corpus: icarus 98 -> 99 (swarm_coordinator). Every spec now COMPILES under Icarus -- zero compile-error specs remain; the eight still out of the gate are runtime divergences only. bridge.v regenerated; unit suite at the single pre-existing red. FROZEN_HASH resealed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 8, 2026 22:55
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1948
let (a, b, c) = (4, 3, 1)— destructuring a tuple literal rather than a call — was unhandled:tuple_local_elem_typesonly recognized typed/call-returning inits, so the local emitted a namelessreg [31:0] ;and= {1, 3, 4}(empty LHS). It infers element types now (default u32) and width-casts the literal elements into the packed temp.tri-net: icarus 98 → 99 (swarm_coordinator). Every spec now compiles under Icarus — zero compile-error specs remain; the eight still out of the gate are runtime divergences only. bridge.v regenerated; unit suite at the single pre-existing red. FROZEN_HASH resealed; NOW.md entries added.
🤖 Generated with Claude Code