ci(icarus-kat): add link_quality_monitor to the GF-T Verilog gate (105 -> 106) - #359
Merged
Merged
Conversation
…5 -> 106) Unlocked by t27#1994 (signed-aware ordered comparison). Verilog was doing an unsigned comparison where a signed i8 operand (trend = -16) met an unsigned const, reading it as 240; it now compares in the signed domain with C integer-promotion semantics, so `is_degrading`'s `trend > TREND_THRESHOLD` matches the Rust/Zig/C backends. This was the last codegen-side runtime divergence. icarus gate 105 -> 106. Only rti_security remains out -- a spec-side assertion arithmetic bug (3*100+10*10+200 asserted == 700, should be 600) that fails under Rust/Zig/C too, not a codegen issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlocked by t27#1994 (signed-aware ordered comparison). Verilog was doing an unsigned comparison where a signed
i8operand (trend = -16) met an unsigned const, reading it as 240; it now compares in the signed domain with C integer-promotion semantics, sois_degrading'strend > TREND_THRESHOLDmatches the Rust/Zig/C backends.This was the last codegen-side runtime divergence. icarus gate 105 -> 106.
Only
rti_securitynow remains out of the gate — a spec-side assertion arithmetic bug (3*100+10*10+200asserted== 700, should be600) that fails under Rust/Zig/C too, not a codegen issue.Local: link_quality_monitor passes all 6 tests; full 105-spec gate re-run: 0 regressions.
🤖 Generated with Claude Code