fix(ws): replace catch unreachable with proper error handling#161
Merged
Conversation
- Changed WSClient.init signature to return !WSClient - Used try for stream.address error propagation - Updated listenerLoop to handle errors with logging and cleanup Closes #160 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gHashTag
pushed a commit
that referenced
this pull request
Mar 18, 2026
- Loop #161 in progress - Call count: 7 - Branch: vibee-v10-tri-economy (73 commits ahead of main) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gHashTag
added a commit
that referenced
this pull request
Mar 18, 2026
fix(ws): replace catch unreachable with proper error handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catch unreachablewith proper error handling inWSClient.init!WSClientfor error propagationlistenerLoopto handle errors gracefully with logging and cleanupChanges
initsignature fromWSClientto!WSClientstream.address catch unreachablewithtry stream.addresslistenerLoopwith proper logging and resource cleanupCloses #160
🤖 Generated with Claude Code