Skip to content

fix(ws): replace catch unreachable with proper error handling #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gHashTag merged 1 commit into from
Mar 11, 2026
Merged

fix(ws): replace catch unreachable with proper error handling #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/tri/websocket/intelligence_server.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,11 @@ pub const WSClient = struct {

mutex: std.Thread.Mutex,

pub fn init(allocator: Allocator, stream: net.Stream) WSClient {
pub fn init(allocator: Allocator, stream: net.Stream) !WSClient {
return .{
.allocator = allocator,
.stream = stream,
.address = stream.address catch unreachable,
.address = try stream.address,
.connected = true,
.mutex = std.Thread.Mutex{},
};
Expand Down Expand Up @@ -370,7 +370,12 @@ pub const WSServer = struct {
stream.close();
continue;
};
client_ptr.* = WSClient.init(server.allocator, stream);
client_ptr.* = WSClient.init(server.allocator, stream) catch |err| {
stdout.print("Failed to get client address: {}\n", .{err}) catch {};
server.allocator.destroy(client_ptr);
stream.close();
continue;
};

server.mutex.lock();
server.clients.append(server.allocator, client_ptr) catch {
Expand Down
Loading