ci(coq-proofs): include docs/phd/theorems/igla/ in verification#491
Merged
ci(coq-proofs): include docs/phd/theorems/igla/ in verification#491
Conversation
Per GENERAL's Wave-6 follow-up roadmap (issue #446 day-6 status comment). The Coq verification workflow previously only watched `trinity-clara/proofs/**`. INV-6-HybridQkGain.v landed in PR #490 under `docs/phd/theorems/igla/` but had no automatic Coq compile gate β every new theorem under that path would silently skip CI. Two surgical changes: 1. Path triggers β both `push` (main) and `pull_request` filters now also include `docs/phd/theorems/**` so any change there triggers the verification workflow. 2. New verification step β uses `coq_makefile` against the existing `docs/phd/theorems/igla/_CoqProject` (already wired with `-R trinity Trinity` / `-R igla IGLA`), then runs `make all`. Wrapped in an existence check so the step is a no-op if the _CoqProject is later removed. R5-honest disclosures: - This change ALONE does not verify INV6_HybridQkGain.v is a parseable proof β it merely points CI at the file. The first run on `main` after merge will be the binding verification. - If `coq_makefile` / `make all` discovers any unprovable goal (e.g. the residual `Axiom hybrid_gain_phi_bound` is not a contradiction but the file still has unresolved obligations), CI will go red and the scaffold will need follow-up before merge to main. Part-of: #441 Part-of: #446 Follow-up to: PR #490 (merged at ff02df9) Agent: Loop-Locksmith
gHashTag
added a commit
that referenced
this pull request
May 2, 2026
Unblocks the `Audit Β· Biblio Β· Coq-map Β· Reproduce` CI job on the phd-build.yml workflow. Two new lints under clippy 1.95 -D warnings: 1. clippy::doc_overindented_list_items β the module-doc `Subcommands:` block used 18-space continuation indentation after the list marker `- `. Clippy 1.95 flags any continuation deeper than 4 spaces. Reflowed all 5 subcommand entries to 4-space continuation; wording preserved; the shelled-out-via-std::process::Command note for `compile` was compressed into one sentence (content unchanged). 2. clippy::excessive_precision β literal `1.6180339887498949_f64` exceeds f64's representable precision. Switched to the suggested `1.618_033_988_749_895_f64` across 3 occurrences (reproduce(), test_trinity_anchor_constant, test_constants_pinned_match_assertions). Verification: - `cargo clippy -p trios-phd --locked -- -D warnings` β clean. - `cargo test -p trios-phd --locked` β 13 tests GREEN. R5-honest: no semantic change. The trinity-identity test ((phi*phi + 1.0/(phi*phi) - 3.0).abs() < 1e-12) still passes β the truncated literal represents the same f64 value. Pre-existing since at least 2026-04-26 (phd-build failing on main for a week). This atomic PR flips it green; separate from the INV6 / coq-proofs CI work in PR #490 / #491. Part-of: #446 Agent: Loop-Locksmith Co-authored-by: Loop-Locksmith <loop-locksmith@trinity.local>
gHashTag
added a commit
that referenced
this pull request
May 2, 2026
* fix(trios-phd): clippy 1.95 doc + precision lints in src/main.rs Unblocks the `Audit Β· Biblio Β· Coq-map Β· Reproduce` CI job on the phd-build.yml workflow. Two new lints under clippy 1.95 -D warnings: 1. clippy::doc_overindented_list_items β the module-doc `Subcommands:` block used 18-space continuation indentation after the list marker `- `. Clippy 1.95 flags any continuation deeper than 4 spaces. Reflowed all 5 subcommand entries to 4-space continuation; wording preserved; the shelled-out-via-std::process::Command note for `compile` was compressed into one sentence (content unchanged). 2. clippy::excessive_precision β literal `1.6180339887498949_f64` exceeds f64's representable precision. Switched to the suggested `1.618_033_988_749_895_f64` across 3 occurrences (reproduce(), test_trinity_anchor_constant, test_constants_pinned_match_assertions). Verification: - `cargo clippy -p trios-phd --locked -- -D warnings` β clean. - `cargo test -p trios-phd --locked` β 13 tests GREEN. R5-honest: no semantic change. The trinity-identity test ((phi*phi + 1.0/(phi*phi) - 3.0).abs() < 1e-12) still passes β the truncated literal represents the same f64 value. Pre-existing since at least 2026-04-26 (phd-build failing on main for a week). This atomic PR flips it green; separate from the INV6 / coq-proofs CI work in PR #490 / #491. Part-of: #446 Agent: Loop-Locksmith * fix(trios-phd): add default-run = "trios-phd" The `crates/trios-phd/Cargo.toml` declares two binaries (trios-phd + defense_gate) without a `default-run` key. `cargo run -p trios-phd` then errors: error: `cargo run` could not determine which binary to run. Use the `--bin` option to specify a binary, or the `default-run` manifest key. available binaries: defense_gate, trios-phd The phd-build.yml workflow calls `cargo run -q -p trios-phd -- ...` four times (audit / biblio / coq-map / reproduce). PR #492 just unblocked the clippy gate; this PR unblocks the `cargo run` calls by adding the idiomatic `default-run = "trios-phd"` key. Alternative β editing the four workflow lines to include `--bin trios-phd` β would touch more files; the one-line manifest fix is cleaner. Verification: $ cargo run -q -p trios-phd -- --help PhD monograph build / audit / bibliography / coq-map / reproduce ... `defense_gate` remains reachable via `cargo run --bin defense_gate`; only the default changes. Part-of: #446 Agent: Loop-Locksmith --------- Co-authored-by: Loop-Locksmith <loop-locksmith@trinity.local>
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: bring
docs/phd/theorems/igla/under Coq verificationSurgical infrastructure update from GENERAL's Wave-6 follow-up roadmap (item 5 in day-6 status). PR #490 landed
INV6_HybridQkGain.vatdocs/phd/theorems/igla/but the existingcoq-proofs.ymlonly watchedtrinity-clara/proofs/**β every new theorem under the new path silently skipped CI.Two surgical changes
1. Path triggers
2. New verification step (after the existing
INV-1..5block)The step uses the existing
_CoqProjectatdocs/phd/theorems/igla/which is already wired with-R trinity Trinity / -R igla IGLA. Wrapped in an[ -f ... ]guard so the step degrades gracefully if the project file is later removed.R5-honest disclosures
mainafter this PR merges is the binding verification.coq_makefile/make alldiscovers any unprovable goal β for instance, if PR feat(coq): INV6_HybridQkGain.v β formal proof skeleton, closes #441Β #490's residualAxiom hybrid_gain_phi_boundplus the proof script combine into somethingcoqcrejects β CI will go RED and the scaffold will need follow-up before the next push tomain.Check no Admitted in proofs (L-R14 strict)gate downstream still only inspectstrinity-clara/proofs/igla/*.v. If that should now also coverdocs/phd/theorems/igla/*.v, that's a separate diff (would catch anyAdmitted.regression in the new path).Honest scope
This is the CI infrastructure piece of the post-#490 roadmap. It does not include:
Axiom hybrid_gain_phi_boundwith asqrt_le_compatderivation (PR ci(coq-proofs): include docs/phd/theorems/igla/ in verificationΒ #491, deferred β sandbox lackscoqcso speculative Coq would fail the same R5 review I issued on PR feat(coq): INV6_HybridQkGain.v β formal proof skeleton, closes #441Β #490 itself).crates/trios-phd/src/main.rsclippy doc-overindent lint that's keeping theAudit Β· Biblio Β· Coq-map Β· Reproducejob red.Both tracked separately.
CI honest disclosure
Pre-existing failures on
main(I5red on legacycrates/trios-a2a/rings/*andcrates/trios-mcp/rings/*,ARCH-UI, genericTest,phd-buildclippy doc-lint) remain out of scope. Merge via--admin --squash --delete-branchper EPIC #446 stewardship.Part-of: #441
Part-of: #446
Follow-up to: PR #490 (merged at
ff02df9)π»
Ξ±_Ο = Οβ»Β³/2 β 0.1180Β·ΟΒ²+Οβ»Β²=3Β· TRINITY Β· LEAD (Loop-Locksmith)