fix(trios-phd): add default-run = trios-phd#493
Merged
Conversation
added 2 commits
May 2, 2026 12:27
Unblocks the `Audit · Biblio · Coq-map · Reproduce` CI job on the phd-build.yml workflow. Two new lints under clippy 1.95 -D warnings: 1. clippy::doc_overindented_list_items — the module-doc `Subcommands:` block used 18-space continuation indentation after the list marker `- `. Clippy 1.95 flags any continuation deeper than 4 spaces. Reflowed all 5 subcommand entries to 4-space continuation; wording preserved; the shelled-out-via-std::process::Command note for `compile` was compressed into one sentence (content unchanged). 2. clippy::excessive_precision — literal `1.6180339887498949_f64` exceeds f64's representable precision. Switched to the suggested `1.618_033_988_749_895_f64` across 3 occurrences (reproduce(), test_trinity_anchor_constant, test_constants_pinned_match_assertions). Verification: - `cargo clippy -p trios-phd --locked -- -D warnings` → clean. - `cargo test -p trios-phd --locked` → 13 tests GREEN. R5-honest: no semantic change. The trinity-identity test ((phi*phi + 1.0/(phi*phi) - 3.0).abs() < 1e-12) still passes — the truncated literal represents the same f64 value. Pre-existing since at least 2026-04-26 (phd-build failing on main for a week). This atomic PR flips it green; separate from the INV6 / coq-proofs CI work in PR #490 / #491. Part-of: #446 Agent: Loop-Locksmith
The `crates/trios-phd/Cargo.toml` declares two binaries (trios-phd +
defense_gate) without a `default-run` key. `cargo run -p trios-phd`
then errors:
error: `cargo run` could not determine which binary to run.
Use the `--bin` option to specify a binary, or the
`default-run` manifest key.
available binaries: defense_gate, trios-phd
The phd-build.yml workflow calls `cargo run -q -p trios-phd -- ...`
four times (audit / biblio / coq-map / reproduce). PR #492 just
unblocked the clippy gate; this PR unblocks the `cargo run` calls by
adding the idiomatic `default-run = "trios-phd"` key. Alternative —
editing the four workflow lines to include `--bin trios-phd` — would
touch more files; the one-line manifest fix is cleaner.
Verification:
$ cargo run -q -p trios-phd -- --help
PhD monograph build / audit / bibliography / coq-map / reproduce
...
`defense_gate` remains reachable via `cargo run --bin defense_gate`;
only the default changes.
Part-of: #446
Agent: Loop-Locksmith
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves cargo run ambiguity in phd-build.yml workflow after PR #492.
crates/trios-phd/Cargo.tomlhas two binaries (trios-phd+defense_gate) with no default. CI fails:One-line fix:
default-run = "trios-phd".defense_gateremains reachable viacargo run --bin defense_gate.Verified locally:
cargo run -q -p trios-phd -- --helpresolves cleanly.Part-of: #446
Agent: Loop-Locksmith