sync with root-inheritance-fix from VRS#441
Conversation
|
|
||
|
|
||
| class _ValueObject(DomainEntity, ABC): | ||
| class _ValueObject(Entity, ABC): |
There was a problem hiding this comment.
I think this is fine, but to be consistent with VRS I wonder if we should remove _ValueObject and just extend Entity?
|
@korikuzma I need some pointers on how to update the pypi stuff (I think) so that the notebooks can be updated to address the fix to the efo: -> EFO: PR that was made to vrs 2.x recently. I'd like to know how to do that if you have the time to show me. |
|
@larrybabb Since we no longer use python jsonschema objects, we have to manually update the source code in VRS-Python. For the notebooks, there are some hard-coded EFOs which would also need to be updated manually. |
|
@larrybabb why was EFO case changed to lowercase in this commit? ga4gh/vrs@cafe826 |
korikuzma
left a comment
korikuzma
left a comment
There was a problem hiding this comment.
Either update notebooks in this PR or separate
2 participants
removed reference to VRS
ValueObjectwhich was removed in VRS branchroot-inheritance-fixPR under review.@korikuzma please check my work and convert let me know how to get this completed and released.