feat: make VRS schema release info accessible in VRS-Python#467
Closed
jsstevenson wants to merge 10 commits intomainfrom
Closed
feat: make VRS schema release info accessible in VRS-Python#467jsstevenson wants to merge 10 commits intomainfrom
jsstevenson wants to merge 10 commits intomainfrom
Conversation
This was referenced Apr 9, 2025
Contributor
Author
|
going with the slightly less elegant #543 instead |
jsstevenson
added a commit
that referenced
this pull request
Apr 11, 2025
supercedes #467. In that PR, I defined a hook for setuptools that would use the tag info in a submodule and auto-update a variable with the latest VRS schema tag, so that wheels built by our release workflow would contain the right value. There were probably going to be some hiccups that way, though, and I also couldn't get it to be testable in github actions on account of how actions/checkout seemed to be pulling the git repos. Here, we just define a little old constant with the schema version. This is a fully manual process, but theoretically we won't need to update it that often, so it should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(draft: don't worry about reviewing yet)
close #85
Current status: for the life of me, I cannot get this to work in CI/CD. Seems to be something about how the GitHub checkout action works and what it does and doesn't get from the
.gitfolder. Not sure how to move forward.