Add jtor to omas viewer plot - #414
Merged
Merged
Conversation
…iewer_plot' of github.com:gafusion/omas into add_jtor_to_omas_viewer_plot
torrinba
approved these changes
May 21, 2026
torrinba
left a comment
Collaborator
There was a problem hiding this comment.
The changes look good to me. They are pretty minimal outside of the plot so I don't think additional testing or a version update is required. I'm surprised other fetching routines didn't complain about the missing mappings for the channel numbers
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
j_torto the equilibrium summary shot. It also fixes a bug where constraints could not be loaded due to missing structure nodes in_efit.json. The downside is that the added structure nodes duplicate the loading of the constraint data making the plot glacially slow.Type of Change
Testing
See the plot #406
Pre-Merge Checklist
omas/versionfile0.94.2→0.94.3for bug fixes,0.94.2→0.95.0for new features)Additional Notes