Skip to content

Add jtor to omas viewer plot - #414

Merged
torrinba merged 4 commits into
add_jpar_mappingfrom
add_jtor_to_omas_viewer_plot
May 21, 2026
Merged

Add jtor to omas viewer plot#414
torrinba merged 4 commits into
add_jpar_mappingfrom
add_jtor_to_omas_viewer_plot

Conversation

@AreWeDreaming

Copy link
Copy Markdown
Collaborator

Description

Adds j_tor to the equilibrium summary shot. It also fixes a bug where constraints could not be loaded due to missing structure nodes in _efit.json. The downside is that the added structure nodes duplicate the loading of the constraint data making the plot glacially slow.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

See the plot #406

Pre-Merge Checklist

  • OMFIT has been tested with this OMAS version and you will create a PR on OMFIT that updates the OMAS submodule once this has been merged.
  • Version number has been incremented if this is a major modification or important bug fix
    • To increment the version: Edit the version number in omas/version file
    • Follow semantic versioning: MAJOR.MINOR.PATCH (e.g., 0.94.20.94.3 for bug fixes, 0.94.20.95.0 for new features)
    • A GitHub release will be automatically created when this PR is merged if the version number has changed

Additional Notes

@torrinba torrinba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. They are pretty minimal outside of the plot so I don't think additional testing or a version update is required. I'm surprised other fetching routines didn't complain about the missing mappings for the channel numbers

@torrinba
torrinba merged commit 7f75ec9 into add_jpar_mapping May 21, 2026
8 checks passed
@torrinba
torrinba deleted the add_jtor_to_omas_viewer_plot branch May 21, 2026 18:00
@AreWeDreaming AreWeDreaming mentioned this pull request May 28, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants