Skip to content

Merge origin/main into origin/dev#1010

Merged
yiiqii merged 4 commits into
devfrom
main
May 23, 2025
Merged

Merge origin/main into origin/dev#1010
yiiqii merged 4 commits into
devfrom
main

Conversation

@yiiqii

@yiiqii yiiqii commented May 23, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes

    • Improved device detection to better support OpenHarmony devices.
  • Chores

    • Updated version numbers to 2.4.3 across multiple packages.
    • Updated changelog files with details for the 2.4.3 patch release.

@yiiqii
yiiqii requested a review from wumaolinmaoan May 23, 2025 03:27
@coderabbitai

coderabbitai Bot commented May 23, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

This update introduces version 2.4.3 across multiple packages, primarily to address a harmony device detection issue. A new function for detecting OpenHarmony devices was added, and the detection logic was updated accordingly. All affected package versions were incremented, and changelogs were updated to reflect the fix.

Changes

Files/Paths Change Summary
CHANGELOG.md, CHANGELOG-zh_CN.md Added entry for version 2.4.3, documenting the harmony device detection fix.
packages/effects-core/src/utils/device.ts Added isOpenHarmony() function and updated isSimulatorCellPhone() to include OpenHarmony detection.
packages/effects-core/package.json
packages/effects-helper/package.json
packages/effects-threejs/package.json
packages/effects-webgl/package.json
packages/effects/package.json
Incremented package version from 2.4.2 to 2.4.3.
plugin-packages/alipay-downgrade/package.json
plugin-packages/downgrade/package.json
plugin-packages/editor-gizmo/package.json
plugin-packages/model/package.json
plugin-packages/multimedia/package.json
plugin-packages/orientation-transformer/package.json
plugin-packages/rich-text/package.json
plugin-packages/spine/package.json
plugin-packages/stats/package.json
Incremented package version from 2.4.2 to 2.4.3.

Sequence Diagram(s)

sequenceDiagram
    participant UserAgent
    participant DeviceUtils

    UserAgent->>DeviceUtils: Call isSimulatorCellPhone()
    DeviceUtils->>DeviceUtils: Check for Android/iOS simulator
    DeviceUtils->>DeviceUtils: Call isOpenHarmony()
    DeviceUtils->>UserAgent: Return detection result (includes OpenHarmony)
Loading

Suggested reviewers

  • wumaolinmaoan

Poem

In the meadow of code, a patch hops in,
Detecting Harmony devices with a whiskered grin.
Versions all bumped, the changelogs now sing,
Of fixes and updates this release did bring.
With a twitch of my nose and a happy "Yay!",
Bugs hop away—let’s ship it today! 🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e22b5f and 2e27d81.

📒 Files selected for processing (17)
  • CHANGELOG-zh_CN.md (1 hunks)
  • CHANGELOG.md (1 hunks)
  • packages/effects-core/package.json (1 hunks)
  • packages/effects-core/src/utils/device.ts (1 hunks)
  • packages/effects-helper/package.json (1 hunks)
  • packages/effects-threejs/package.json (1 hunks)
  • packages/effects-webgl/package.json (1 hunks)
  • packages/effects/package.json (1 hunks)
  • plugin-packages/alipay-downgrade/package.json (1 hunks)
  • plugin-packages/downgrade/package.json (1 hunks)
  • plugin-packages/editor-gizmo/package.json (1 hunks)
  • plugin-packages/model/package.json (1 hunks)
  • plugin-packages/multimedia/package.json (1 hunks)
  • plugin-packages/orientation-transformer/package.json (1 hunks)
  • plugin-packages/rich-text/package.json (1 hunks)
  • plugin-packages/spine/package.json (1 hunks)
  • plugin-packages/stats/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (18)
packages/effects-core/src/utils/device.ts (2)

29-31: LGTM! Well-implemented OpenHarmony detection function.

The function correctly uses word boundaries in the regex pattern to ensure accurate detection of OpenHarmony devices via the user agent string. The implementation follows the same pattern as existing device detection functions in this module.


34-34: LGTM! Proper integration of OpenHarmony detection.

The addition of isOpenHarmony() to the isSimulatorCellPhone() function is logical and maintains consistency with the existing detection logic for Android and iOS devices.

packages/effects-core/package.json (1)

3-3: LGTM! Appropriate patch version increment.

The version bump from 2.4.2 to 2.4.3 correctly follows semantic versioning for a patch release addressing the harmony device detection issue.

packages/effects-webgl/package.json (1)

3-3: LGTM! Consistent version increment across packages.

The version bump maintains consistency with the coordinated 2.4.3 patch release across the monorepo packages.

packages/effects-helper/package.json (1)

3-3: LGTM! Completes the coordinated version update.

The version bump maintains consistency with the other packages in this coordinated 2.4.3 patch release.

packages/effects/package.json (1)

3-3: Confirm version bump to 2.4.3.
The package version was correctly updated to 2.4.3 for the patch addressing the harmony device detection fix.

plugin-packages/rich-text/package.json (1)

3-3: Confirm version bump to 2.4.3.
The @galacean/effects-plugin-rich-text package version aligns with the coordinated 2.4.3 release.

plugin-packages/downgrade/package.json (1)

3-3: Confirm version bump to 2.4.3.
The @galacean/effects-plugin-downgrade package version was incremented appropriately for the 2.4.3 patch.

plugin-packages/multimedia/package.json (1)

3-3: Confirm version bump to 2.4.3.
The @galacean/effects-plugin-multimedia package version update is consistent with the patch release.

plugin-packages/stats/package.json (1)

3-3: Confirm version bump to 2.4.3.
The @galacean/effects-plugin-stats package version correctly reflects the 2.4.3 release.

plugin-packages/spine/package.json (1)

3-3: Version bump to 2.4.3 appropriate
The package version has been correctly updated to reflect the 2.4.3 patch release.

CHANGELOG-zh_CN.md (1)

11-15: Changelog entry for 2.4.3 is accurate
The new patch (2.4.3) entry includes the correct date and references PR #1006 for the harmony device detection fix.

plugin-packages/editor-gizmo/package.json (1)

3-3: Version bump to 2.4.3 appropriate
Consistent with the coordinated release across all plugin packages.

packages/effects-threejs/package.json (1)

3-3: Version bump to 2.4.3 appropriate
Matches the release version in core and other plugin packages.

plugin-packages/orientation-transformer/package.json (1)

3-3: Version bump to 2.4.3 appropriate
Reflects the patch release across all packages in this coordinated update.

plugin-packages/model/package.json (1)

3-3: Consistent patch release version bump.
The package version has been correctly incremented from 2.4.2 to 2.4.3, aligning this plugin with the coordinated patch release across all related packages.

CHANGELOG.md (1)

10-14: Accurate changelog entry for v2.4.3.
The new section for 2.4.3 is formatted correctly, includes the release date 2025-05-21, and references PR #1006 with the contributor. It follows the existing changelog conventions.

plugin-packages/alipay-downgrade/package.json (1)

3-3: Aligned version bump for Alipay downgrade plugin.
The version field correctly updates from 2.4.2 to 2.4.3 in this plugin’s package.json, matching the overall patch release strategy.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yiiqii
yiiqii merged commit 62e638e into dev May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants