-
Notifications
You must be signed in to change notification settings - Fork 496
Add ENA Webin cli as a Galaxy tool #6807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bgruening Is it normal that I get an error like this "No repository named ena_webin_cli found with owner iuc" "remote_repository_url" https://github.com/galaxyproject/tools-iuc/tree/main/tools/ena_webin_cli does not yet exist off course but don't know if that is the problem. |
bgruening
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is not normal, can you add a citation and then we see this is just a wired mix up.
|
@bgruening I think this is ready for review! |
bgruening
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know its a larger rearchitecture, but do you think its feasilbly that we hide the web-cli tool in a pythons script and read the credetials straight from the YML file in python?
That way we do not expose any credentials as ENV var. We read the password from the yaml and pass them with subprocess to the cli-command.
| @@ -0,0 +1,280 @@ | |||
| <tool id="ena_webin_cli" name="ENA Webin CLI" version="@TOOL_VERSION@+galaxy@VERSION_SUFFIX@" python_template_version="3.5" license="MIT"> | |||
| <description>Submission of consensus sequences to the European Nucleotide Archive (ENA)</description> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <description>Submission of consensus sequences to the European Nucleotide Archive (ENA)</description> | |
| <description>Submission of consensus sequences to the ENA</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like the more verbose description 🤔
|
Thanks for the review! I will get back to it soon! |
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
Co-authored-by: Björn Grüning <bjoern@gruenings.eu>
|
@bgruening Thanks a lot for merging. I did start with a more secure wrapping, and I plan to make a PR for it. I was wondering if the tool could be installed also on usegalaxy.eu? |
|
If you need it feel free to add it to https://github.com/usegalaxy-eu/usegalaxy-eu-tools |
FOR CONTRIBUTOR:
This work is done in collaboration with ENA to make bring submission/validation functionalities of ENA to Galaxy. This tool will live next to the
ena_uploadGalaxy tool which is focused on RAW read submissions. This tool will be focused on Assemblies and other types of analysis submissions. The goal is to make it work well in combination with theena_uploadGalaxy tool.To Do's
ena_uploadGalaxy toolena_upload