Refactoring HPsystem - #1019
Merged
tturocy merged 2 commits intoAug 3, 2026
Merged
Conversation
tturocy
self-requested a review
August 2, 2026 19:23
tturocy
requested changes
Aug 2, 2026
| void HPEquationSystem::GetJacobian(const Vector<double> &point, Matrix<double> &p_jac) const | ||
| { | ||
| // Update internal mutable state | ||
| int temp_alpha_idx = 2; |
Member
There was a problem hiding this comment.
This loop is repeated between GetValue and GetJacobian; would be suitable for a small helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes in this PR
Refactoring of
hpsystem.handhpsystem.cc.Now they follow the structure of
nfglogit.cc, where each kind of equation has its own class that inherits fromHPEquation.No bugs have been found while testing them with the
pytestsuite and the games fromcontrib.