Reject malformed AGG/BAGG headers before construction - #971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a pre-existing crash surfaced by CI
Description of the changes in this PR
Fixes a segfault in the AGG/BAGG file readers on malformed input.
Cause: malformed input (e.g. an
.nfgtoread_bagg, or a degenerate"0 0 0"header)slipped past the header checks and dereferenced an empty vector in the AGG constructor, segfaulting.
The parser code is unchanged from
masterand runs before any label normalization.Fix: validate header fields before construction; malformed headers now raise
ValueError, valid files are unaffected.Tests:
test_read_agg_zero_header/test_read_bagg_zero_headerread"0 0 0\n"and expectValueError.These segfault on unpatched code (taking down the pytest process, as in CI) rather than failing as an assertion.