Claude/update prod runner script lq2g s

[gamblecodezcom]

CodeAnt-AI Description

Make disk cleanup reliable and add safer VPS deploy with recovery

What Changed

• File cleanup now safely handles filenames with spaces/special characters and logs each deleted file; failures to delete or compress files are reported instead of silently ignored.
• Cleanup routines (logs, temp files, snapshots) use a single robust delete helper and report totals; critical runtime files are checked after cleanup and missing files emit warnings.
• Deploy script loads only notification credentials from .env (avoids exporting unrelated variables) and skips redeploy if the service is already active on the latest commit.
• Deploys now track whether the service was stopped and will attempt to restart the service automatically if git or npm steps fail, keeping the bot running on the last known-good code or dependencies.
• Admin notifications include clearer failure context and recovery attempts; npm and git failures restart the previous service and send diagnostics to admins.

Impact

✅ Fewer accidental file-losses during cleanup
✅ Shorter downtime after failed deploys
✅ Clearer deploy failure and recovery notifications

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[codeant-ai]

CodeAnt AI is reviewing your PR.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Two deployment and disk-protection shell scripts are enhanced with improved error handling, state tracking, and safety mechanisms. Deploy.sh adds pre-deployment checks, service recovery logic, and selective environment variable loading. Disk-protect.sh introduces a centralized file deletion helper function and critical file safety verification.

Changes

Cohort / File(s)	Summary
Deployment logic improvements deploy.sh	Adds pre-deployment hash comparison to skip redundant deploys; introduces service recovery state tracking (_SERVICE_STOPPED flag); refactors error handler to derive line numbers from BASH_LINENO; implements conditional npm dependency installation (npm ci vs. npm install); selectively extracts and exports only BOT_TOKEN and ADMIN_IDS from .env instead of loading the entire file; improves error messaging and recovery paths for git and service operations.
Disk protection and safety scripts/disk-protect.sh	Introduces delete_found helper function for centralized, null-delimited file deletion with per-file logging; refactors multiple find-based deletion patterns to use the new helper; enhances input parsing with IFS guards for journalctl and npm cache operations; adds Step 8 critical file safety check with toggle flag; improves final disk usage logging consistency.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Service states now tracked with care,
Recovery paths through the air,
Safer deletions, checks so bright,
Deploy scripts running left and right,
Shell scripts strengthened, bugs take flight!

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codeant-ai]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Possible Bug The script stores the npm command as a single string in NPM_CMD and later attempts to run it via command substitution: NPM_OUT=$(${NPM_CMD} 2>&1). Because NPM_CMD contains spaces, this will attempt to execute a single command name that includes spaces (and fail). Use a command array or eval to run a composed command. This is a runtime logic bug that will prevent dependency installation and leave the service recovery logic active.

[codeant-ai]

Suggestion: Because the script uses set -euo pipefail, a non-zero exit status from journalctl --vacuum-size (for example, due to insufficient permissions) will cause the entire disk-protect script to abort at Step 4, skipping later cleanup and safety checks even though the journal vacuum is intended as a best-effort, non-critical operation; adding a guard to ignore failures here prevents unintended termination. [logic error]

Severity Level: Major ⚠️

- ⚠️ Disk cleanup script aborts at journal vacuum step.
- ⚠️ Later log compression and temp file cleanup skipped.
- ⚠️ Safety check for .env and runtime-state.json may skip.

Suggested change

	done
	done || true

Steps of Reproduction ✅

1. Install the weekly disk-protect cron job by running `/workspace/Runewager/prod-run.sh`,
which writes `0 3 * * 0 $DISK_PROTECT_SCRIPT >> ${PROJECT_DIR}/logs/disk-protect.log 2>&1`
into crontab (see `/workspace/Runewager/prod-run.sh`, disk-protect block around lines
22–32 in the shown snippet).

2. Ensure the cron (or manual) execution runs
`/workspace/Runewager/scripts/disk-protect.sh` as a non-root user that lacks permission to
vacuum the systemd journal (file `/workspace/Runewager/scripts/disk-protect.sh`, `set -euo
pipefail` at line 12 and Step 4 at lines 85–92).

3. When Step 4 executes, `journalctl --vacuum-size="${JOURNAL_VACUUM_MB}M"` (line 87)
exits with a non-zero status due to insufficient permissions; with `set -e` and `pipefail`
enabled, this non-zero pipeline exit causes the entire script to terminate immediately
because the pipeline is not guarded by `|| true` or an `if` condition.

4. Observe in `logs/disk-protect.log` that log messages for later steps (e.g., "Step 5:
Clear npm cache" at line 95, "Step 6: Clear temp files…" at line 104, safety check "Step
8" at line 124, and disk usage summary "Step 9" at line 139) are missing, confirming that
the script aborted at Step 4 instead of treating journal vacuum as best-effort.

Prompt for AI Agent 🤖

This is a comment left during a code review.

**Path:** scripts/disk-protect.sh
**Line:** 89:89
**Comment:**
	*Logic Error: Because the script uses `set -euo pipefail`, a non-zero exit status from `journalctl --vacuum-size` (for example, due to insufficient permissions) will cause the entire disk-protect script to abort at Step 4, skipping later cleanup and safety checks even though the journal vacuum is intended as a best-effort, non-critical operation; adding a guard to ignore failures here prevents unintended termination.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

👍 | 👎

[codeant-ai]

Suggestion: With set -euo pipefail enabled, a non-zero exit from npm cache clean --force will cause the whole script to exit at Step 5 even though clearing the npm cache is non-critical, and it will still log "npm cache cleared" on failure; wrapping this pipeline in an if and handling the failure explicitly avoids terminating the script and ensures success is logged only when the command actually succeeds. [logic error]

Severity Level: Major ⚠️

- ⚠️ Npm cache errors abort script before later cleanup steps.
- ⚠️ No dedicated error log for npm cache failures.

Suggested change

	if command -v npm >/dev/null 2>&1; then
	npm cache clean --force 2>&1 | tail -1 | while read -r line; do log " [npm] $line"; done
	npm cache clean --force 2>&1 | tail -1 | while IFS= read -r line; do log " [npm] $line"; done
	log " npm cache cleared"
	if command -v npm >/devnull 2>&1; then
	if npm cache clean --force 2>&1 | tail -1 | while IFS= read -r line; do log " [npm] $line"; done; then
	log " npm cache cleared"
	else
	warn " npm cache clear failed (non-fatal)"
	fi

Steps of Reproduction ✅

1. Ensure `/workspace/Runewager/scripts/disk-protect.sh` is executed with `set -euo
pipefail` enabled (line 12) either via the cron job installed in
`/workspace/Runewager/prod-run.sh` (disk-protect cron block around lines 22–32 in the
shown snippet) or by invoking the script manually.

2. Run the script on a system where `npm` is present (`command -v npm >/dev/null 2>&1` at
line 96 succeeds) but where `npm cache clean --force` will exit with a non-zero status
(for example, due to permission problems or a corrupted npm cache), causing the pipeline
at line 97 to fail.

3. When Step 5 executes, the pipeline `npm cache clean --force 2>&1 | tail -1 | while ...`
(line 97) returns a non-zero exit status; under `set -e` with `pipefail`, this unguarded
failing pipeline causes the entire `disk-protect.sh` script to terminate at Step 5.

4. Observe in `logs/disk-protect.log` that subsequent steps (Step 6 temp file cleanup at
lines 104–111, Step 7 backup pruning at lines 114–119, Step 8 safety check at lines
124–136, and Step 9 disk usage summary at lines 139–145) are missing, confirming that an
npm cache error aborted the disk-protect run instead of being treated as best-effort.

Prompt for AI Agent 🤖

This is a comment left during a code review.

**Path:** scripts/disk-protect.sh
**Line:** 96:98
**Comment:**
	*Logic Error: With `set -euo pipefail` enabled, a non-zero exit from `npm cache clean --force` will cause the whole script to exit at Step 5 even though clearing the npm cache is non-critical, and it will still log "npm cache cleared" on failure; wrapping this pipeline in an `if` and handling the failure explicitly avoids terminating the script and ensures success is logged only when the command actually succeeds.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

👍 | 👎

[codeant-ai]

CodeAnt AI finished reviewing your PR.