Skip to content

prepare dist folder for bfg - #2

Merged
webbertakken merged 5 commits into
mainfrom
prepare-for-bfg
Sep 1, 2022
Merged

prepare dist folder for bfg#2
webbertakken merged 5 commits into
mainfrom
prepare-for-bfg

Conversation

@webbertakken

@webbertakken webbertakken commented Sep 1, 2022

Copy link
Copy Markdown
Member

Changes

  • We need to clean the repo from years of writing index.js, index.js.map and licenses.txt.
  • Same for package.json and yarn.lock, so I decided to remove the node ecosystem entirely
  • I'm using BFG to delete the dist folder, as well as any file above 1M

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@github-actions

github-actions Bot commented Sep 1, 2022

Copy link
Copy Markdown

Cat Gif

@codecov-commenter

codecov-commenter commented Sep 1, 2022

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@webbertakken
webbertakken merged commit 2c4a5fb into main Sep 1, 2022
@webbertakken
webbertakken deleted the prepare-for-bfg branch September 1, 2022 21:52
webbertakken added a commit that referenced this pull request Sep 1, 2022
* prepare dist folder for bfg

* refactor: remove node ecosystem

* refactor: disable heavy workflows

* chore: run coverage in ci

* chore: add coverage token

Former-commit-id: 2b24c6c572de95a6910ce8dfe4fc825d22d48787
frostebite added a commit that referenced this pull request Aug 14, 2026
Yarn Berry disables install-time lifecycle scripts by default, so the
prepare script never actually built this package when consumed as a
git dependency (confirmed: unity-activate#111's Tests check failed
with "Cannot find module '@game-ci/unity-engine-core/dist/...'").
Same fix the action repos already use — commit dist/, verify it's not
stale in CI — rather than depending on scripts running at install time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants