Skip to content

feat: register build options#22

Merged
webbertakken merged 1 commit into
mainfrom
register-build-options
Sep 7, 2022
Merged

feat: register build options#22
webbertakken merged 1 commit into
mainfrom
register-build-options

Conversation

@webbertakken

Copy link
Copy Markdown
Member

Changes

  • This correctly registeres the options for the build command and exposes a flaw in the multi-engine logic (we don't have a way to differentiate between engines and have different cli options for each engine, depending on the project, because middleware cannot add options (not sure if yargs has a good reason for that, will need to investigate))

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@webbertakken webbertakken merged commit 02152ee into main Sep 7, 2022
@webbertakken webbertakken deleted the register-build-options branch September 7, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant