fix panel installation

[et-nik]

Summary by CodeRabbit

• Improvements
  • Improved installation and enrollment error messages to clarify startup failures.
  • Added post-install guidance recommending a reboot after system package upgrades.
  • Improved service recovery after previous failed startup attempts.
  • Package operations now run more reliably with fewer interactive prompts.
  • Installed services now wait for required database services and include improved startup protection.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 57d4dff1-c5c4-453f-9b64-16b2848eb320

📥 Commits

Reviewing files that changed from the base of the PR and between 1cdefc2 and 01a8195.

📒 Files selected for processing (1)

• internal/actions/panel/install/panel_install_v4.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• gameap/gameap.github.io (manual)

🚧 Files skipped from review as they are similar to previous changes (1)

• internal/actions/panel/install/panel_install_v4.go

---

📝 Walkthrough

Walkthrough

Changes

Linux installation and startup

Layer / File(s)	Summary
Shared APT environment pkg/package_manager/apt.go, pkg/package_manager/apt_internal_test.go, pkg/package_manager/apt_strategy.go	APT commands use a shared environment with noninteractive mode, needrestart suspension, locale settings, and preserved process variables.
Panel systemd unit rendering pkg/panel/install_linux.go, pkg/panel/install_linux_test.go, pkg/panel/templates_linux.go	Systemd unit rendering uses a helper. The unit waits for database services and defines updated start-limit settings. Tests verify the rendered configuration.
Failed service state recovery pkg/service/service.go, pkg/daemon/daemon_start_unix.go	Systemd start and restart operations reset failed states. User-scoped daemon startup also resets the failed state and ignores reset errors.
Installer completion messages internal/actions/panel/install/panel_install_v4.go	Installation and daemon enrollment startup errors identify their context. Post-install output recommends a reboot after system package upgrades.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• gameap/gameapctl#23: Related changes affect the same panel installation, daemon startup, and systemd unit code paths.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main purpose of the changes, which address panel installation and startup behavior.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands.}

[coveralls]

Coverage Report for CI Build 31108345881

Coverage increased (+0.2%) to 13.459%

Details

• Coverage increased (+0.2%) from the base build.
• Patch coverage: 40 uncovered changes across 6 files (9 of 49 lines covered, 18.37%).
• 1 coverage regression across 1 file.

Uncovered Changes

File	Changed	Covered	%
pkg/service/service.go	17	0	0.0%
pkg/panel/install_linux.go	10	2	20.0%
internal/actions/panel/install/panel_install_v4.go	6	0	0.0%
pkg/package_manager/apt.go	12	7	58.33%
pkg/daemon/daemon_start_unix.go	3	0	0.0%
pkg/package_manager/apt_strategy.go	1	0	0.0%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File	Lines Losing Coverage	Coverage
pkg/panel/install_linux.go	1	33.33%

---

Coverage Stats

Relevant Lines:	13842
Covered Lines:	1863
Line Coverage:	13.46%
Coverage Strength:	10.47 hits per line

---

💛 - Coveralls

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/package_manager/apt.go`:
- Around line 26-36: Update the noneDatabase completion path for APT
prerequisite installation to emit the existing reboot recommendation before
returning, reusing the same guidance used by the normal completion path;
alternatively restart the affected services there. Ensure this applies when apt
installs missing prerequisites while preserving the existing aptEnv behavior.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d9e13108-6052-48ee-99de-3da92532f529

📥 Commits

Reviewing files that changed from the base of the PR and between 3063f65 and 1cdefc2.

📒 Files selected for processing (9)

• internal/actions/panel/install/panel_install_v4.go
• pkg/daemon/daemon_start_unix.go
• pkg/package_manager/apt.go
• pkg/package_manager/apt_internal_test.go
• pkg/package_manager/apt_strategy.go
• pkg/panel/install_linux.go
• pkg/panel/install_linux_test.go
• pkg/panel/templates_linux.go
• pkg/service/service.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• gameap/gameap.github.io (manual)