-
Notifications
You must be signed in to change notification settings - Fork 7
Interface update #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Interface update #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a/DecisionProgramming.jl into interface-influence-diagram pulling from origin before push.
…d all its sub-structs. Adjusted the datatypes in InfluenceDiagram accordingly.
…ion AddNode! and changed validate_node accordingly. Commented out old definitions of these structs.
…ram! to work with the new datatypes and structs.
…l we decide how we want to implement these.
…ed primitive types.
This concludes Helmi's summer work, I'm merging this now and we can continue the development towards v1 in this branch
paulaweller
reviewed
Oct 12, 2021
Contributor
paulaweller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small comments, nothing serious.
Co-authored-by: paulaweller <72554386+paulaweller@users.noreply.github.com>
paulaweller
reviewed
Oct 12, 2021
Co-authored-by: paulaweller <72554386+paulaweller@users.noreply.github.com>
paulaweller
reviewed
Oct 15, 2021
Co-authored-by: paulaweller <72554386+paulaweller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major updates to the user interface and documentation.