Skip to content

inverted verifyCert condition in src/curl.c #61

Description

@dirkmueller

In src/curl.c (line 133), the condition if (verifyCert == True) triggers the disabling of SSL/TLS certificate peer and hostname verification:

if (verifyCert == True) {
    curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
    curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);
}

In GAP, verifyCert defaults to true (as defined in gap/curl.gi). Consequently, default configurations will explicitly disable certificate validation under the hood. Conversely, setting verifyCert := false skips this block and leaves libcurl's default validation enabled.

This seems oddly the wrong way around?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions