Let Centralizer( U, g ) work if g is not contained in U#114
Let Centralizer( U, g ) work if g is not contained in U#114fingolfin merged 2 commits intogap-packages:masterfrom
Centralizer( U, g ) work if g is not contained in U#114Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 55.82% 56.08% +0.25%
==========================================
Files 87 87
Lines 12678 12687 +9
==========================================
+ Hits 7078 7115 +37
+ Misses 5600 5572 -28
🚀 New features to boost your workflow:
|
| # | ||
| gap> G := ExamplesOfSomePcpGroups( 5 );; | ||
| gap> H := Subgroup( G, [ G.1 ] );; | ||
| gap> C := Centralizer( H, G.2 ); | ||
| Pcp-group with orders [ 0 ] | ||
| gap> C = Subgroup( G, [ G.4 ] ); | ||
| true |
There was a problem hiding this comment.
What specifically is this test testing? Perhaps the comment could indicate that? Or is it just arbitrary?
There was a problem hiding this comment.
The goal was to test the calculation of a centralizer of a pair [ H, g ] with g not contained in H. I've added a comment and expanded the tests a bit.
| # | ||
| gap> G := PcGroupToPcpGroup( PcGroupCode( 520, 16 ) );; | ||
| gap> g := G.1*G.3*G.4;; | ||
| gap> H := Subgroup( G,[ G.2, G.3, G.4 ] );; | ||
| gap> Centralizer( H, g ); | ||
| Pcp-group with orders [ 2, 2 ] |
There was a problem hiding this comment.
Similar question here. Since you moved it here and removed the comment, I assume this is no longer relying on the fallback. So... it's just testing a centralizer in a finite group?
By the way, both tests are element centralizers, not subgroup centralizers; maybe one for that case should also be added? (But it might be too much work, just wondering)
There was a problem hiding this comment.
Since you moved it here and removed the comment, I assume this is no longer relying on the fallback. So... it's just testing a centralizer in a finite group?
It's indeed no longer relying on the fallback, but instead on Intersection. Similar to the other example, but for a finite group this time.
I've also added an example where we calculate Centralizer( H, K ) for two subgroups H and K.
2 participants
This supersedes #68, and is related to the discussion in #111.
The functionality is still limited because
Intersectiondoes not work in all cases, but it's still an improvement. This should also avoid relying on generic GAP methods that run forever for infinite groups.