Allow Centralizer to fall back on generic GAP methods#68
Merged
fingolfin merged 13 commits intogap-packages:masterfrom Aug 27, 2025
stertooy:centralizer_allow_fallback
Merged
Allow Centralizer to fall back on generic GAP methods#68fingolfin merged 13 commits intogap-packages:masterfrom stertooy:centralizer_allow_fallback
fingolfin merged 13 commits intogap-packages:masterfrom
stertooy:centralizer_allow_fallback
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 57.22% 57.27% +0.05%
==========================================
Files 87 87
Lines 13095 13095
==========================================
+ Hits 7493 7500 +7
+ Misses 5602 5595 -7
🚀 New features to boost your workflow:
|
fingolfin
reviewed
May 17, 2021
| # check | ||
| if ForAny( g, x -> not x in G ) then | ||
| Error("elements must be contained in group"); | ||
| TryNextMethod(); |
Member
There was a problem hiding this comment.
I haven't checked yet, but: is this actually a requirement for CentralizerBySeries to work correctly? Or is perhaps the test above wrong and instead the check is supposed to check that the g are elements of the parent of G / the full group of the underlying collector?
Contributor
Author
There was a problem hiding this comment.
Unfortunately, it seems like this is really a requirement. In both the nilpotent and in the general case I get incorrect results for the centralizer.
gap> G := SmallGroup( 16, 8 );; # QD16, Nilpotent
gap> U := Subgroup( G, [ G.2*G.3*G.4 ] );;
gap> g := G.1*G.2*G.3*G.4;;
gap> Centralizer( U, g );
Group([ ])
gap> iso := IsomorphismPcpGroup( G );;
gap> G := Image( iso, G );;U := Image( iso, U );;g := Image( iso, g );;
gap> CentralizerPcpGroup( U, g );
Pcp-group with orders [ 2 ]
gap> CentralizerNilpotentPcpGroup( U, g );
Pcp-group with orders [ 2 ]
Update with master
Put conjugacy fix in all fixes branch
Fix bug in AddToIgs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #64. Of course, if there is a reason for forcing this error, this shouldn't be merged.