Add constructive recognition of SL(2,q) in natural representation 2.0#398
Merged
fingolfin merged 21 commits intogap-packages:masterfrom Apr 30, 2026
Merged
Add constructive recognition of SL(2,q) in natural representation 2.0#398fingolfin merged 21 commits intogap-packages:masterfrom
fingolfin merged 21 commits intogap-packages:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 80.07% 87.46% +7.38%
==========================================
Files 44 45 +1
Lines 18382 18873 +491
==========================================
+ Hits 14720 16507 +1787
+ Misses 3662 2366 -1296
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
adf24f1 to
b696b3d
Compare
fingolfin
reviewed
Mar 24, 2026
a72680f to
15f167c
Compare
fingolfin
reviewed
Mar 24, 2026
ef2aec5 to
ec12c2c
Compare
fingolfin
reviewed
Mar 28, 2026
366d8ad to
eb4ca8b
Compare
Member
|
I found some small issues, hopefully fixed in pull request #434. Thanks for testing the code and reporting the problems. |
ccdcde3 to
aa7920b
Compare
aa7920b to
b9b8c64
Compare
238288c to
b54d1b3
Compare
Collaborator
Author
|
After the recent changes, I benchmarked The following timings illustrate this behaviour: |
fingolfin
reviewed
Apr 7, 2026
b198aea to
e01b541
Compare
fingolfin
reviewed
Apr 21, 2026
1375c4a to
42b86ad
Compare
fingolfin
reviewed
Apr 21, 2026
c4e037d to
7cdc0b1
Compare
7cdc0b1 to
10cfede
Compare
fingolfin
approved these changes
Apr 28, 2026
Co-authored-by: Max Horn <max@quendi.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces PR #389, which encountered merge conflicts. Starting fresh with a clean branch.
It is about adding Frank Lübeck's RECOG.RecogNaturalSL2 algorithm for constructive recognition of SL(2,q) in natural representation, along with RECOG.ConRecogNaturalSL2 which wraps it and produces output in the same format as RECOG.RecogniseSL2NaturalEvenChar / RECOG.RecogniseSL2NaturalOddCharUsingBSGS.
For q=3 where RecogNaturalSL2 does not work, the function falls back to existing recognition methods.