Fixes for RecogNaturalSL2#434
Open
frankluebeck wants to merge 1 commit intogap-packages:masterfrom
Open
Conversation
Member
frankluebeck
commented
Mar 31, 2026
frankluebeck
commented
- mention and catch that algorithm only works for q >= 5
- simplified (and fixed?) search condition for ym
- made search for cm less restrictive (should now also work for q=5)
- fixed that in char two the expoment i was sometimes wrong
- mention and catch that algorithm only works for q >= 5 - simplified (and fixed?) search condition for ym - made search for cm less restrictive (should now also work for q=5) - fixed that in char two the expoment i was sometimes wrong
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #434 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 44 44
Lines 18384 18384
=======================================
Hits 14794 14794
Misses 3590 3590 🚀 New features to boost your workflow:
|
Member
|
Thanks @frankluebeck ! |
fingolfin
reviewed
Apr 1, 2026
| elif q mod 2 = 0 then | ||
| i := (q-1-log)/2; | ||
| # in char two r is always a square | ||
| i := log/2 mod (q-1); |
Member
There was a problem hiding this comment.
So maybe just this?
Suggested change
| i := log/2 mod (q-1); | |
| i := (q-1+log)/2; |
fingolfin
reviewed
Apr 1, 2026
| elif q mod 2 = 0 then | ||
| i := (q-1-log)/2; | ||
| # in char two r is always a square | ||
| i := log/2 mod (q-1); |
Member
There was a problem hiding this comment.
Suggested change
| i := log/2 mod (q-1); | |
| i := (q-1+log)/2; |
Till-Eisen
pushed a commit
to Till-Eisen/recog_SL_recog
that referenced
this pull request
Apr 1, 2026
Till-Eisen
pushed a commit
to Till-Eisen/recog_SL_recog
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.