Not sure how to best download packages in test-all.yml:
- using
download_packages.py has the advantage that we really test the packages in the commit this action runs on
- downloading a
packages.tar.gz from a given ensures we really test the tarball we later offer to users; but it requires a download URL for such a package
In practice, I envision that this is run from either ...
- a PR workflow (to test whether a PR is ready to be merged),
- upon a
push to the main branch (to test a packages.tar.gz we just assembled),
- as part of a scheduled cron job, to test for regressions introduced in GAP
master
For the first scenario, it makes sense to use download_packages.py; for the other two scenarios, I'd say the second approach makes more sense. So perhaps both should be supported, by turning the pkgarchiveurl into an optional argument?
Originally posted by @fingolfin in #78 (comment)
Not sure how to best download packages in
test-all.yml:download_packages.pyhas the advantage that we really test the packages in the commit this action runs onpackages.tar.gzfrom a given ensures we really test the tarball we later offer to users; but it requires a download URL for such a packageIn practice, I envision that this is run from either ...
pushto themainbranch (to test apackages.tar.gzwe just assembled),masterFor the first scenario, it makes sense to use
download_packages.py; for the other two scenarios, I'd say the second approach makes more sense. So perhaps both should be supported, by turning thepkgarchiveurlinto an optional argument?Originally posted by @fingolfin in #78 (comment)