fix(ssh): pin the agent socket in Host * - #180
Merged
Merged
Conversation
Every private key is in the Bitwarden agent, and the contexts that most need it — launchd agents, the mutagen daemon — are the ones never handed SSH_AUTH_SOCK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-provisioning from #179 fired correctly on the first ssh to rpi4 and then failed to create the session:
Same root cause as #177, one level up. No private key is on disk; they all live in the Bitwarden agent.
mutagen sync createhands the connection to the mutagen daemon, which has its own environment and noSSH_AUTH_SOCK, so it sees no keys. It worked for macmini and mvrx only because those two entries happen to pinIdentityAgentthemselves.Putting it in
Host *fixes the class rather than the instance, and matches what is actually true on this machine. Per-host entries that set their ownIdentityAgentstill win.Verified with the variable removed from the environment entirely: