Enhance update-images.py with directives and comment preservation#1572
Merged
ccwienk merged 2 commits intogardener:masterfrom Apr 22, 2026
Merged
Enhance update-images.py with directives and comment preservation#1572ccwienk merged 2 commits intogardener:masterfrom
ccwienk merged 2 commits intogardener:masterfrom
Conversation
- Add 'freeze' directive to prevent updates on specific entries - Add 'max-supported-k8s' directive to prevent new k8s version entries - Add 'version-mapping' directive for GCP CCM version format - Preserve custom comments in images.yaml output - Handle manual k8s constraints (e.g., csi-provisioner '>= 1.34') - Fix comment indentation in YAML output
wpross
requested review from
8R0WNI3,
TuanAnh17N,
ccwienk and
zkdev
as code owners
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
Bot
added
do-not-merge/needs-kind
ccwienk
reviewed
Apr 22, 2026
- Move directives out of ImageEntry dataclass into separate DirectivesMap - Replace methods with standalone helper functions - Rename 'manual k8s constraint' to 'explicit k8s constraint' - Use math.inf for yaml.width instead of magic number - Add explicit check for 'images' key in YAML - Pass yaml_content to load_and_validate instead of re-reading file
This was referenced Apr 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: