Support Multiple Cost Object Types in Configuration#2102
Merged
petersutter merged 2 commits intomasterfrom Sep 25, 2024
Merged
Conversation
grolu
reviewed
Sep 24, 2024
grolu
approved these changes
Sep 24, 2024
Member
grolu
left a comment
There was a problem hiding this comment.
/lgtm apart from minor styling issue
1cf2667 to
b32d5ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enhances the existing cost object configuration by allowing administrators to define multiple cost object types. Users can then select from these predefined types in the UI. The update introduces a dropdown menu where users can choose between different cost object types configured by the administrator.
Previously, the cost object value was stored under
annotations["billing.gardener.cloud/costObject"]on theProject. With this update, the newly introduced type is stored underannotations["billing.gardener.cloud/costObjectType"].Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
Enhanced cost object configuration to support multiple cost object types. The selected type is now stored under `Project.annotations["billing.gardener.cloud/costObjectType"]`.