Skip to content

Drop get-token#2131

Merged
petersutter merged 1 commit intomasterfrom
drop-get-token
Oct 14, 2024
Merged

Drop get-token#2131
petersutter merged 1 commit intomasterfrom
drop-get-token

Conversation

@petersutter
Copy link
Member

@petersutter petersutter commented Oct 9, 2024 •
edited
Loading

What this PR does / why we need it:
This PR removes the functionality to retrieve the user token from the My Account page.
This feature was only added for debugging purposes, and there should be no need to retrieve the token for productive use of the UI.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Enable Hide whitespace for an efficient review of the changes.

Release note:

Removed the ability for users to retrieve their token from the My Account page.

@gardener-robot gardener-robot added needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 9, 2024
holgerkoser
holgerkoser approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 11, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 11, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 11, 2024
grolu
grolu approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grolu grolu mentioned this pull request Oct 14, 2024
Open
@petersutter petersutter merged commit d4b9ad8 into master Oct 14, 2024
@petersutter petersutter deleted the drop-get-token branch October 14, 2024 13:50
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 14, 2024
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

Assignees

No one assigned

Labels

area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petersutter @holgerkoser @grolu @gardener-robot-ci-2 @gardener-robot