Skip to content

Drop support of static token kubeconfig#2171

Merged
petersutter merged 1 commit intomasterfrom
drop-static-token-kubeconfig-support
Nov 21, 2024
Merged

Drop support of static token kubeconfig#2171
petersutter merged 1 commit intomasterfrom
drop-static-token-kubeconfig-support

Conversation

@petersutter
Copy link
Member

@petersutter petersutter commented Nov 7, 2024

What this PR does / why we need it:
With this PR, static token kubeconfig support is dropped from the dashboard. This feature became obsolete with Kubernetes versions 1.27 or higher, as the enableStaticTokenKubeconfig field is permanently set to false starting with Kubernetes 1.27.

Which issue(s) this PR fixes:
Fixes #1595

Special notes for your reviewer:
Related change in g/g gardener/gardener#10664

Release note:

Static token kubeconfig support has been removed from the dashboard. This feature is no longer needed as of Kubernetes version `1.27`, where the `enableStaticTokenKubeconfig` field is permanently set to `false`.

@gardener-robot gardener-robot added needs/review Needs review size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Nov 7, 2024
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 7, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 7, 2024
@petersutter petersutter force-pushed the drop-static-token-kubeconfig-support branch from be45922 to a18fc71 Compare November 7, 2024 14:46
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 7, 2024
holgerkoser
holgerkoser approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
beside of the lodash array syntax issue

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 8, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 8, 2024
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Nov 13, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
@petersutter petersutter force-pushed the drop-static-token-kubeconfig-support branch from fc5fcb0 to 76a1be7 Compare November 13, 2024 12:19
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
grolu
grolu approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Nov 21, 2024
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2024
@petersutter petersutter merged commit c4868f1 into master Nov 21, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 21, 2024
holgerkoser added a commit that referenced this pull request Nov 21, 2024
@holgerkoser
Merge branch 'master' into enh/codemirror
6942da2 
* master:
  fix: ul must not be a child of p (#2193)
  Fix deprecated Sass `@import` rules (#2186)
  Drop static token kubeconfig support (#2171)
  Bump @eslint/plugin-kit from 0.2.0 to 0.2.3 (#2187)
@petersutter petersutter deleted the drop-static-token-kubeconfig-support branch December 16, 2024 14:41
@petersutter petersutter mentioned this pull request Jan 8, 2025
Closed
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 23, 2025
@grolu grolu mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

Assignees

No one assigned

Labels

area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Static token kubeconfigs for k8s version >= 1.27

6 participants

@petersutter @holgerkoser @grolu @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot