Skip to content

Fix readonly editor#2176

Merged
grolu merged 4 commits intomasterfrom
bug/fix-readonly-editor
Nov 13, 2024
Merged

Fix readonly editor#2176
grolu merged 4 commits intomasterfrom
bug/fix-readonly-editor

Conversation

@grolu
Copy link
Member

@grolu grolu commented Nov 13, 2024 •
edited
Loading

What this PR does / why we need it:
Use readonly state to make editor non editable. This fixes search behavior.

Which issue(s) this PR fixes:
Fixes #2166

Special notes for your reviewer:

Release note:

Resolved an issue where the editor search did not function correctly for non-editable clusters, such as 'Purpose: Infrastructure'

@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 13, 2024
petersutter
petersutter approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 13, 2024
@grolu grolu merged commit 6d6b153 into master Nov 13, 2024
@grolu grolu deleted the bug/fix-readonly-editor branch November 13, 2024 14:41
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 13, 2024
holgerkoser added a commit that referenced this pull request Nov 15, 2024
@holgerkoser
Merge branch 'master' into openmfp
39333da 
* master:
  temporarily disable sass major and minor updates
  Update Monthly Dev Dependencies (#2181)
  Update fsfe/reuse-action action to v5 (#2182)
  fix alertmanager url (#2178)
  temporarily disable dockerfile-ast and sass updates
  replaced set editor readonly state instead of editable view (#2176)
  Migrate config .github/renovate.json5 (#2177)
  Update renovate.json5
  Update dependency express-static-gzip to v2.2.0 (#2172)
  Do not wrap lodash because of linter (#2174)

# Conflicts:
#	.pnp.cjs
#	frontend/src/views/GAdministration.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser holgerkoser is a code owner

Assignees

No one assigned

Labels

needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search in YAML not working properly for Shoots in garden namespace

4 participants

@grolu @petersutter @gardener-robot-ci-2 @gardener-robot