Skip to content

Use a polling watcher instead of chokidar#2202

Merged
holgerkoser merged 2 commits intomasterfrom
enh/polling-watcher
Nov 28, 2024
Merged

Use a polling watcher instead of chokidar#2202
holgerkoser merged 2 commits intomasterfrom
enh/polling-watcher

Conversation

@holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented Nov 26, 2024

What this PR does / why we need it:
Use a polling watcher approach instead of chokidar for watching kube-config files

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Switched to a polling-based watcher approach for kube-config files, as we've observed that some filesystem events can be missed by chokidar.

@gardener-robot gardener-robot added the needs/review Needs review label Nov 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 26, 2024
@gardener-robot gardener-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Nov 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 26, 2024
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 27, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2024
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Nov 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 27, 2024
@holgerkoser holgerkoser merged commit 77f60e2 into master Nov 28, 2024
@holgerkoser holgerkoser deleted the enh/polling-watcher branch November 28, 2024 09:36
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 28, 2024
holgerkoser added a commit that referenced this pull request Dec 3, 2024
* master:
  Update yarn `prod-install` plugin sources (#2212)
  Move polling watcher to own package (#2208)
  Update dependency vuetify to v3.7.5 (#2216)
  Update dependency vite to v6 (#2214)
  fix tests (#2215)
  Update Monthly Dev Dependencies (#2213)
  Optimize CodeMirror Integration with Dynamic Imports (#2206)
  Added lint-sarif script to output lint results in SARIF format (#2210)
  Update dependency @codemirror/language to v6.10.6 (#2211)
  Update dependency pinia to v2.2.8 (#2209)
  Update vueuse monorepo to v12 (#2203)
  migrate to polling watcher (remove chokidar) (#2202)
  Update dependency pinia to v2.2.7 (#2205)
  Update dependency @codemirror/language to v6.10.5 (#2204)

# Conflicts:
#	.pnp.cjs
#	yarn.lock
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants