Skip to content

fix: Use correct link for control plane high availability documentation#2225

Merged
petersutter merged 1 commit intogardener:masterfrom
marc1404:fix/control-plane-high-availability-link
Dec 9, 2024
Merged

fix: Use correct link for control plane high availability documentation#2225
petersutter merged 1 commit intogardener:masterfrom
marc1404:fix/control-plane-high-availability-link

Conversation

@marc1404
Copy link
Member

@marc1404 marc1404 commented Dec 9, 2024

What this PR does / why we need it:

The external link to the control plane high-availability page is broken.

Actual:
https://github.com/gardener/gardener/blob/master/docs/usage/shoot_high_availability.md

Expected:
https://github.com/gardener/gardener/blob/master/docs/usage/high-availability/shoot_high_availability.md

Screenshot 2024-12-09 at 11 28 51

Which issue(s) this PR fixes:

n.a.

Special notes for your reviewer:

Should the link use the Gardener documentation homepage instead?
👉 https://gardener.cloud/docs/gardener/high-availability/shoot_high_availability/

Release note:

Fix the link reference to the control plane high availability page.

@gardener-robot gardener-robot added the needs/review Needs review label Dec 9, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 9, 2024
@gardener-robot gardener-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 9, 2024
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 9, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 9, 2024
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks

@petersutter
Copy link
Member

Should the link use the Gardener documentation homepage instead?
👉 https://gardener.cloud/docs/gardener/high-availability/shoot_high_availability/

let's leave this PR as is as we have other places that would need to be fixed as well to make it consistent. We can improve in a separate PR

@petersutter petersutter merged commit 95e62e0 into gardener:master Dec 9, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 9, 2024
@marc1404 marc1404 deleted the fix/control-plane-high-availability-link branch December 9, 2024 13:14
holgerkoser added a commit that referenced this pull request Dec 11, 2024
* master:
  fix: Use correct URL for shoot credentials rotation page (#2221)
  fix: Use correct link for control plane high availability documentation (#2225)
  Update dependency @codemirror/view to v6.35.2 (#2224)
  Update dependency @codemirror/view to v6.35.1 (#2220)
  Update dependency express to v4.21.2 (#2219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants